[#891] Add weekly stats snapshot cron + vercel.json#910
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The weekly snapshot route itself is plausible, but the vercel.json change registers an airdrop cron that this repo does not expose in a Vercel-compatible form.
Findings
- [high]
vercel.jsonschedules/api/cron/airdrop-pointsevery 5 minutes, but this PR does not add a matchingGETcron route or adapter for that path. The PR body itself notes that the existing airdrop-points route exportsPOST, which means this scheduled job will not run successfully as registered.- File:
vercel.json:7 - Suggestion: Either add a
GET /api/cron/airdrop-pointsadapter that matches Vercel cron invocation, or remove this cron registration from the PR until the route supports it.
- File:
Decision
Requesting changes because the PR claims to register all 3 airdrop crons correctly, but one of those scheduled entries is not actually invokable in production as configured.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up update resolves the cron-registration issue from my prior review. vercel.json now only registers the two GET-compatible airdrop crons implemented in this repo: airdrop-price and airdrop-weekly.
Findings
- No remaining code-level blockers in the changed files.
Decision
Approving because the weekly snapshot cron and cron registration I reviewed now match issue #891.
Fixes #891
Summary
pl_weekly_snapshotspl_daily_pricesairdrop-pointsevery 5 min (note: route exports POST — may need GET adapter for Vercel cron)airdrop-pricedaily at midnight UTCairdrop-weeklyMonday midnight UTCTest plan
🤖 Generated with Claude Code