[#916] Fix streak tier drop logic to drop to previous tier#921
Merged
realproject7 merged 1 commit intomainfrom Apr 21, 2026
Merged
[#916] Fix streak tier drop logic to drop to previous tier#921realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
dropOneTier was snapping to the current tier threshold instead of dropping to the one below. E.g. streak 50 stayed at 50 instead of dropping to 30. Fixed: streak now drops to previous tier (100→50, 50→30, 30→14, 14→7, 7→0). Fixes #916 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Owner
Author
re2 Review — APPROVED ✅Verified against
The fix is a single index shift: |
project7-interns
approved these changes
Apr 21, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR corrects dropOneTier() to drop to the previous streak threshold instead of snapping to the current one. The implementation now matches issue #916's stated behavior for 100, 50, 7, and sub-7 streaks.
Findings
- None.
Decision
Approve. I verified the threshold ordering and the updated logic now yields the intended tier drops. CI checks were still pending at review time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dropOneTier()was snapping to the current tier threshold instead of the previous oneFixes #916
Test plan
dropOneTier(100)returns 50dropOneTier(50)returns 30dropOneTier(7)returns 0dropOneTier(3)returns 0🤖 Generated with Claude Code