[#928] Switch from MCap to FDV (price x max supply) on /airdrop and /token#934
[#928] Switch from MCap to FDV (price x max supply) on /airdrop and /token#934realproject7 merged 1 commit intomainfrom
Conversation
…token - Add PLOT_MAX_SUPPLY = 1,000,000 constant - Cron: store FDV (price * 1M) in mcap_usd column instead of MCap - useTokenInfo: compute FDV (price * max supply) instead of MCap - /token page: label "FDV" instead of "Market Cap" - Status API: rename currentMcap -> currentFdv in response - CampaignHero/MilestoneTrack: update StatusData interfaces - WeeklySnapshots: label "FDV" instead of "MCap" FDV = PLOT USD price * 1,000,000 (max supply). No Mint Club MCap API. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
left a comment
realproject7
left a comment
There was a problem hiding this comment.
re2 verdict: APPROVE
Clean MCap→FDV switch across 9 files:
PLOT_MAX_SUPPLY = 1_000_000added to shared constants- Cron stores
price × PLOT_MAX_SUPPLY(FDV) instead ofprice × circulating supply(MCap) - Status API:
currentMcap→currentFdv useTokenInfo:marketCap→fdv, uses shared constant- Token page + WeeklySnapshots: labels updated
- Component interfaces updated
Non-blocking note: The mcap_usd DB column now stores FDV going forward, but historical rows contain MCap values. This creates a data discontinuity in WeeklySnapshots for older weeks. Consider a column rename or backfill as follow-up.
No blocking issues.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR switches the airdrop and token flows from MCap semantics to FDV semantics using the explicit max-supply constant, updates the main UI labels to "FDV", and updates the daily snapshot cron to store the FDV-based value used by milestone tracking.
Findings
- None.
Decision
Approving. Residual risk is limited to the still-pending CI checks (e2e, lint-and-typecheck), but I did not find a code-level blocker in the reviewed changes.
2 participants
Summary
Fixes #928
Switches all MCap references to FDV (Fully Diluted Valuation = price * 1,000,000 max supply):
lib/contracts/constants.ts— AddedPLOT_MAX_SUPPLY = 1_000_000airdrop-price): Stores FDV inmcap_usdcolumn (price * max supply, not circulating)useTokenInfo: Computesfdv= price * PLOT_MAX_SUPPLY (renamed frommarketCap)/tokenpage: Label changed from "Market Cap" to "FDV"currentMcap->currentFdvNo Mint Club MCap API calls used for this calculation.
Test plan
/tokenpage shows "FDV" label with correct value/airdropcomponents reference FDV (not MCap)🤖 Generated with Claude Code