[#938] Fix chart: empty state, projection, mobile overflow#941
Merged
realproject7 merged 2 commits intomainfrom Apr 22, 2026
Merged
[#938] Fix chart: empty state, projection, mobile overflow#941realproject7 merged 2 commits intomainfrom
realproject7 merged 2 commits intomainfrom
Conversation
- Show current FDV point and $0 pool line when no daily price history - Heartbeat dot always visible at current FDV position - Pool value line renders flat $0 pre-Bronze or stepped if in a tier - Remove minWidth:320 to let SVG scale freely on mobile - Hide axis labels and Y-left ticks on mobile (< 640px) Fixes #938 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
requested changes
Apr 22, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The empty-state changes are close, but there is still a correctness bug in the timeline positioning before the campaign starts.
Findings
- [high] Empty-state current point can render left of the chart before campaign start
- File:
src/components/airdrop/CampaignHero.tsx:183 - Suggestion: clamp the time used for
nowXto the campaign window on both ends, not just the upper bound. Right nowtimeToX(Math.min(nowMs, endMs), ...)allows dates beforecampaignStart, so before kickoff the synthesized point/heartbeat/pool path can be drawn left ofPAD.leftand partially disappear. Use something likeMath.max(startMs, Math.min(nowMs, endMs)).
- File:
Decision
Requesting changes because the new acceptance criterion says the chart should still show the current state even before there is daily history, and this case still breaks before the campaign window begins.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Apr 22, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The requested timeline clamp fix is in place, and the empty-state/mobile chart updates now satisfy the issue requirements.
Findings
- None.
Decision
Approving because the prior blocking issue was resolved and the required checks are now passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pl_daily_prices), so the chart never looks emptyminWidth: 320that caused horizontal scroll on mobile; axis labels and Y-left ticks hidden on small screens via Tailwind responsive classesFixes #938
Test plan
🤖 Generated with Claude Code