[#944] Fix FDV display and mobile chart readability#946
Merged
realproject7 merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
- Status API now falls back to live getPlotUsdPrice() when pl_daily_prices has no data, computing FDV as price × 1M max supply - Increased SVG chart font sizes from 8-9px to 11-12px for mobile readability - Widened right padding to accommodate larger milestone labels - Y-left ticks and axis labels already hidden on mobile from #938 Fixes #944 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 22, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The status API now falls back to a live price for FDV, and the chart typography/readability changes address the mobile issue without changing the core chart behavior.
Findings
- None.
Decision
Approving because the change matches the acceptance criteria and the required checks are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getPlotUsdPrice()whenpl_daily_priceshas no snapshots, so FDV always shows when PLOT has a live priceFixes #944
Test plan
🤖 Generated with Claude Code