Open
Conversation
8b2f66e to
b7f15b0
Compare
* test(rtop): capture stderr in integration test for Windows * ci: setup tmate * test(rtop): avoid running rtop in windows 4.14.* * ci: enable 5.4.0 in windows * ci: remove action-tmate * ci: revert all changes, keep building * ci: add -preasonrtop in esy-ci * ci: update cache keys * ci: fix Windows CI failures - Disable rtopIntegration test on Windows due to lambda-term segfault when stdout is not a real console handle (ConPTY issue on GH Actions). See: ocaml-community/lambda-term#125 - Add setup-mingw step in esy-ci for Windows to provide x86_64-w64-mingw32-gcc needed to compile lambda-term C stubs. - Bump esy cache keys to v0.0.2 to avoid stale caches. * ci: replace setup-mingw action with direct choco install The egor-tensin/setup-mingw@v2 action fails on MinGW 15.2.0 because its cleanup script tries to remove libpthread.dll.a which no longer exists in UCRT-based builds. Use choco directly and add the bin directory to PATH manually. * ci: esy-ci doesn't run rtop tests on windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It generate syntactically wrong code:
https://melange.re/unstable/playground/?language=Reason&code=bGV0IHg6IHQgPSB4OwpsZXQgKHggYXMgeSk6IHQgPSB4OwpsZXQgKCh4LCB5KSBhcyBwYWlyKTogdCA9IHg7CmxldCAoU29tZSh4KSBhcyBvcHQpOiB0ID0gb3B0OwpsZXQgKHt1cmwsIG1vZGV9IGFzIHRhcmdldCk6IHQgPSB4OwpsZXQgKHt1cmwsIG1vZGUsIHByb3RvY29sfSBhcyB0YXJnZXQpOiBUYXJnZXRULlNhZmUudCA9CiAgbXVsdGlUYXJnZXQtPk11bHRpVGFyZ2V0VC50b0lnbm9yYWJsZVRhcmdldFQ7CmxldCAoe3VybCwgbW9kZX0pOiB0ID0geDs%3D&live=on
This PR ensures that if there's an alias, we wrap in parens