Skip to content

ci: pin lambda-term to fork with Windows segfault fix #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davesnx wants to merge 2 commits into from
+18 −8
Closed

ci: pin lambda-term to fork with Windows segfault fix #2915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40409db
ci: pin lambda-term to fork with Windows segfault fix
davesnx Mar 4, 2026
b0cc731
ci: fix opam pin syntax to actually install the patched lambda-term
davesnx Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/opam-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,20 @@ jobs:
uses: actions/cache/restore@v4
with:
path: ~/.opam
key: v0.0.1-opam-${{ matrix.setup.os }}-${{ matrix.setup.ocaml-compiler }}-${{ hashFiles('*.opam') }}
key: v0.0.2-opam-${{ matrix.setup.os }}-${{ matrix.setup.ocaml-compiler }}-${{ hashFiles('*.opam') }}

- name: Load opam cache when Windows
if: runner.os == 'Windows'
id: opam-cache-windows
uses: actions/cache/restore@v4
with:
path: _opam
key: v0.0.1-opam-${{ matrix.setup.os }}-${{ matrix.setup.ocaml-compiler }}-${{ hashFiles('**.opam') }}
key: v0.0.2-opam-${{ matrix.setup.os }}-${{ matrix.setup.ocaml-compiler }}-${{ hashFiles('**.opam') }}

- name: Pin lambda-term to fix Windows segfault
if: runner.os == 'Windows'
run: |
opam pin add lambda-term git+https://github.com/davesnx/lambda-term.git#fix-windows-console-segfault -y

- name: Install dependencies
run: opam install . --deps-only
Expand Down Expand Up @@ -88,12 +93,12 @@ jobs:
if: steps.opam-cache.outputs.cache-hit != 'true' && runner.os != 'Windows'
with:
path: ~/.opam
key: v0.0.1-opam-${{ matrix.setup.os }}-${{ matrix.setup.ocaml-compiler }}-${{ hashFiles('**.opam') }}
key: v0.0.2-opam-${{ matrix.setup.os }}-${{ matrix.setup.ocaml-compiler }}-${{ hashFiles('**.opam') }}

- name: Save cache when Windows
uses: actions/cache/save@v4
if: steps.opam-cache-windows.outputs.cache-hit != 'true' && runner.os == 'Windows'
with:
path: _opam
key: v0.0.1-opam-${{ matrix.setup.os }}-${{ matrix.setup.ocaml-compiler }}-${{ hashFiles('**.opam') }}
key: v0.0.2-opam-${{ matrix.setup.os }}-${{ matrix.setup.ocaml-compiler }}-${{ hashFiles('**.opam') }}

13 changes: 9 additions & 4 deletions test/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,17 @@
./lib/outcometreePrinter.exe
./lib/fdLeak.exe))

; rtopIntegration is disabled on Windows due to a segfault in lambda-term's
; Windows C stubs when stdout is not a real console handle (ConPTY issue).
; rtopIntegration on Windows requires lambda-term with the ConPTY segfault fix.
; See: https://github.com/ocaml-community/lambda-term/pull/125
; Re-enable on Windows once lambda-term ships the fix.
; On Windows, only enabled for OCaml >= 5.0 (opam-ci pins the fixed lambda-term).
; esy-ci uses 4.14 so the test is naturally skipped there.
(cram
(applies_to rtopIntegration)
(package rtop)
(enabled_if (= %{os_type} Unix))
(enabled_if
(or
(= %{os_type} Unix)
(and
(= %{os_type} Win32)
(>= %{ocaml_version} 5.0.0))))
(deps %{bin:ocamlc} %{bin:rtop}))
Loading