Conversation
joseluiz
suggested changes
Dec 5, 2023
joseluiz
left a comment
joseluiz
left a comment
There was a problem hiding this comment.
Hi Rebeca. I left a few comments on things you need to fix.
I saw you opted to implement the alternate code assignment. If you are not confident to implement the preferred assignment, feel free to schedule a 1 on 1 with me or if you prefer you can ask questions on Slack. I can help you with this.
| const express = require('express'); | ||
| const app = express(); | ||
|
|
||
| const mainRouter = require('./routes/main') |
There was a problem hiding this comment.
You imported the main router, but you forgot to use it.
Add the following line right above the 'app.use(notFoundMiddleware);':
app.use("/api/v1", mainRouter);
|
|
||
| res.status(200).json({msg: 'user created', token}) | ||
|
|
||
| res.send('Fake Login') |
There was a problem hiding this comment.
You can remove this line. It's not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.