Update media3 to 1.9.2#2342
Conversation
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
This fails on the videos we tried to patch with our UpdatedMatroskaExtractor. See sample_three_seekheads.mkv and sample_recursive_seekhead.mkv.
Nice thanks for samples I was wondering how to test that as yeah wasn't sure. Will look. |
It is perhaps better to push our changes upstream and wait for 1.9.1. However the review team at android is really bad, and only exists to bikeshed. So it is a 50/50 if that is even viable. |
Missed some upstream fixes in rollback commits
Should be fixed, tested with those files now, some changes in rollback commits weren't applied (I assumed rollback was only rollback and not other random changes also so didn't check to apply those)
Seeing as how a PR already exists for it upstream and no progress on it perhaps we should still do this for now? As I really am not confident it will be merged by 1.9.1. |
|
@fire-light42 just to mention it since you approved this now, #2078 should be merged first, this also bumps minSdk just to make it pass but the other PR also does |
|
@fire-light42 seemed to cause ERROR_CODE_FAILED_RUNTIME_CHECK on most videos when using Software Decoding. Changing to HW works all others gives that. Not sure why as it didnt happen when testing initially. Update found out why, reverting nextlib should in theory fix it. Happens due to subtitle changes in nextlib. So only fatals if using certain subtitle types due to NextTextRenderer not enable legacy Decoding it seems. |
|
anilbeesetti/nextlib@f11ca49 probably caused it so just going back to 1.9.1-0.10.1 should in theory fix it. |
2 participants
This also requires minSdk 23 (#2078) first.
It also applies all patches for
UpdatedDefaultExtractorsFactoryandUpdatedMatroskaExtractorfrom upstream, but converting from Java to Kotlin there is some potential I did it wrong so may need more reviewing or testing.