Merged
Conversation
Claude hook failures showed up as exit 127 when the runtime had an empty or sparse PATH. The installer already knows the absolute Node and CLI paths, so preserve user hook entries while replacing only stale Colony hook commands with the absolute-node form. Uninstall now removes only Colony hook entries instead of deleting the user's adjacent Claude hooks. Constraint: Claude Code stores hooks as shell command strings, so the installed command must not rely on PATH resolution. Rejected: Re-run the old installer as-is | it would clobber custom PostToolUse and Stop hooks in ~/.claude/settings.json. Confidence: high Scope-risk: narrow Directive: Do not replace entire Claude hook event arrays without preserving non-Colony user hooks. Tested: pnpm --filter @colony/installers test Tested: pnpm --filter @colony/installers typecheck Tested: pnpm --filter @colony/installers build Tested: pnpm exec biome check packages/installers/src/claude-code.ts packages/installers/test/installers.test.ts .changeset/claude-hook-path-independence.md Tested: empty-PATH live Claude PostToolUse and Stop hook commands exit 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).