Preserve unknown identity for unclassified lanes#60
Merged
Conversation
The previous owner repair made Codex branches display correctly, but the fallback path also converted truly unclassified active-session CLI values to codex. Keep the fallback as unknown unless branch, session key, or recorded CLI provides a concrete signal. Constraint: Worker viewer uses HivemindSession.cli as a display fallback when agent is generic. Rejected: Hide unknown only in viewer | MCP/API consumers would still receive incorrect codex ownership. Confidence: high Scope-risk: narrow Directive: Do not default active-session cli identity to codex without a concrete identity signal. Tested: node /home/deadpool/Documents/recodee/agents-hivemind/node_modules/.pnpm/vitest@2.1.9_@types+node@22.19.17/node_modules/vitest/vitest.mjs run test/hivemind.test.ts Tested: node /home/deadpool/Documents/recodee/agents-hivemind/node_modules/.pnpm/vitest@2.1.9_@types+node@22.19.17/node_modules/vitest/vitest.mjs run Tested: node /home/deadpool/Documents/recodee/agents-hivemind/node_modules/.pnpm/@biomejs+biome@1.9.4/node_modules/@biomejs/biome/bin/biome check packages/core/src/hivemind.ts packages/core/test/hivemind.test.ts Not-tested: full workspace typecheck; existing baseline lacks @types/better-sqlite3
NagyVikt
deleted the
agent/codex/fix-unknown-cli-fallback-2026-04-25-00-25
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).