Conversation
A successful PR merge was still leaving gx branch finish with a non-zero exit when the trailing remote branch delete raced with an already-removed ref. The cleanup step now treats that specific already-gone state as success while keeping other remote delete failures strict, and the finish suite now covers the race explicitly. Constraint: branch-finish cleanup must stay strict for real remote delete failures while tolerating post-merge ref races Rejected: ignore all remote delete failures with || true | would hide real cleanup regressions after merge Confidence: high Scope-risk: narrow Reversibility: clean Directive: treat only the already-gone remote ref case as idempotent success; keep other push-delete errors fatal Tested: bash -n scripts/agent-branch-finish.sh templates/scripts/agent-branch-finish.sh; node --test test/finish.test.js Not-tested: full live branch finish against GitHub before this commit
NagyVikt
deleted the
agent/codex/fix-branch-finish-remote-delete-tail-2026-04-22-15-42
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).