Stage parent gitlinks without status heuristics#362
Merged
Conversation
Registered submodules can ignore pointer changes strongly enough that git add leaves the parent index unchanged. The finish flow now stages the exact nested HEAD with git update-index --cacheinfo after validating the parent path is already a 160000 gitlink. Constraint: Parent repositories can hide submodule diffs through both diff.ignoreSubmodules and submodule.<path>.ignore. Rejected: Keep using git add after SHA detection | live dogfood showed git add can still leave the gitlink index unchanged. Confidence: high Scope-risk: narrow Directive: Parent gitlink staging is intentionally cacheinfo-based and limited to existing 160000 entries only. Tested: bash -n scripts/agent-branch-finish.sh; bash -n templates/scripts/agent-branch-finish.sh; node --test test/finish.test.js; openspec validate agent-codex-auto-commit-parent-subrepo-upgrades-2026-04-23-11-59 --strict; git diff --check Not-tested: Full npm test after cacheinfo follow-up; full suite passed before the dogfood fixes
NagyVikt
deleted the
agent/codex/stage-parent-gitlink-cacheinfo-2026-04-23-12-19
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).