Skip to content

Stop advertising a file icon theme from Active Agents #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagyVikt merged 1 commit into from
Apr 23, 2026
Merged

Stop advertising a file icon theme from Active Agents #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions templates/vscode/guardex-active-agents/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "GitGuardex Active Agents",
"description": "Shows live Guardex sandbox sessions and repo changes in a dedicated VS Code Active Agents sidebar.",
"publisher": "recodeee",
"version": "0.0.13",
"version": "0.0.14",
"license": "MIT",
"icon": "icon.png",
"engines": {
Expand All @@ -22,13 +22,6 @@
],
"main": "./extension.js",
"contributes": {
"iconThemes": [
{
"id": "gitguardex-file-icons",
"label": "GitGuardex File Icons",
"path": "./fileicons/gitguardex-fileicons.json"
}
],
"commands": [
{
"command": "gitguardex.activeAgents.startAgent",
Expand Down
28 changes: 4 additions & 24 deletions test/vscode-active-agents-session-state.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,7 +1215,7 @@ test('install-vscode-active-agents-extension installs the current extension into
assert.equal(installedManifest.icon, 'icon.png');
assert.equal(installedManifest.version, manifest.version);
assert.deepEqual(installedManifest.activationEvents, manifest.activationEvents);
assert.deepEqual(installedManifest.contributes.iconThemes, manifest.contributes.iconThemes);
assert.equal(installedManifest.contributes.iconThemes, undefined);
assert.equal(installedManifest.activationEvents.includes('onStartupFinished'), true);
assert.equal(fs.existsSync(path.join(canonicalDir, 'icon.png')), true);
assert.equal(fs.existsSync(path.join(canonicalDir, 'fileicons', 'gitguardex-fileicons.json')), true);
Expand Down Expand Up @@ -1251,7 +1251,7 @@ test('active-agents extension edits require a higher manifest version than the b
templateManifest.activationEvents,
'Live and template Active Agents activation events must stay in sync.',
);
assert.deepEqual(
assert.equal(
liveManifest.contributes.iconThemes,
templateManifest.contributes.iconThemes,
'Live and template Active Agents icon theme contributions must stay in sync.',
Expand Down Expand Up @@ -1297,29 +1297,9 @@ test('active-agents manifest uses a dedicated activity bar container with a hive
]);
});

test('active-agents file icon theme maps Guardex workflow paths and ships referenced assets', () => {
test('active-agents manifest does not contribute a file icon theme', () => {
const manifest = readExtensionManifest();
const themeContribution = manifest.contributes.iconThemes.find((entry) => entry.id === 'gitguardex-file-icons');
assert.ok(themeContribution, 'Expected the GitGuardex file icon theme contribution.');
assert.equal(themeContribution.path, './fileicons/gitguardex-fileicons.json');

const themePath = path.join(path.dirname(extensionManifestPath), themeContribution.path);
const theme = readJson(themePath);
assert.equal(theme.folderNames.changes, '_gitguardex_openspec');
assert.equal(theme.folderNames.plan, '_gitguardex_plan');
assert.equal(theme.folderNames.specs, '_gitguardex_spec');
assert.equal(theme.folderNames['agent-worktrees'], '_gitguardex_branch');
assert.equal(theme.folderNames['.githooks'], '_gitguardex_hook');
assert.equal(theme.fileNames['AGENTS.md'], '_gitguardex_agent');
assert.equal(theme.fileNames['proposal.md'], '_gitguardex_openspec');
assert.equal(theme.fileNames['tasks.md'], '_gitguardex_plan');
assert.equal(theme.fileNames['spec.md'], '_gitguardex_spec');
assert.equal(theme.fileNames['pre-commit'], '_gitguardex_hook');

for (const definition of Object.values(theme.iconDefinitions)) {
assert.equal(typeof definition.iconPath, 'string');
assert.equal(fs.existsSync(path.join(path.dirname(themePath), definition.iconPath)), true);
}
assert.equal(manifest.contributes.iconThemes, undefined);
});

test('active-agents extension auto-installs a newer workspace build and offers reload', async () => {
Expand Down
9 changes: 1 addition & 8 deletions vscode/guardex-active-agents/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "GitGuardex Active Agents",
"description": "Shows live Guardex sandbox sessions and repo changes in a dedicated VS Code Active Agents sidebar.",
"publisher": "recodeee",
"version": "0.0.13",
"version": "0.0.14",
"license": "MIT",
"icon": "icon.png",
"engines": {
Expand All @@ -22,13 +22,6 @@
],
"main": "./extension.js",
"contributes": {
"iconThemes": [
{
"id": "gitguardex-file-icons",
"label": "GitGuardex File Icons",
"path": "./fileicons/gitguardex-fileicons.json"
}
],
"commands": [
{
"command": "gitguardex.activeAgents.startAgent",
Expand Down