Skip to content

Keep merged OpenSpec cleanup evidence truthful #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagyVikt merged 1 commit into from
Apr 23, 2026
Merged

Keep merged OpenSpec cleanup evidence truthful #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...c/changes/agent-codex-add-openspec-and-provider-icons-2026-04-23-16-49/tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ Handoff: 2026-04-23 codex owns branch `agent/codex/add-openspec-and-provider-ico

## 4. Cleanup (mandatory; run before claiming completion)

- [ ] 4.1 Run `gx branch finish --branch "agent/codex/add-openspec-and-provider-icons-2026-04-23-16-49" --base main --via-pr --wait-for-merge --cleanup`.
- [ ] 4.2 Record the PR URL and final `MERGED` state in the completion handoff.
- [ ] 4.3 Confirm the sandbox worktree and branch refs are gone after cleanup.
- [x] 4.1 Run `gx branch finish --branch "agent/codex/add-openspec-and-provider-icons-2026-04-23-16-49" --base main --via-pr --wait-for-merge --cleanup`. Result: merged via PR flow, cleaned the source agent worktree, and reported `Merged 'agent/codex/add-openspec-and-provider-icons-2026-04-23-16-49' into 'main' via pr flow and cleaned source branch/worktree.`
- [x] 4.2 Record the PR URL and final `MERGED` state in the completion handoff. Result: `gh pr view agent/codex/add-openspec-and-provider-icons-2026-04-23-16-49 --json url,state,mergedAt,mergeCommit` returned `https://github.com/recodeee/gitguardex/pull/380`, `MERGED`, `2026-04-23T14:53:31Z`, merge commit `c78d52058f680a78c03caef446edf6783e087cb1`.
- [x] 4.3 Confirm the sandbox worktree and branch refs are gone after cleanup. Result: `git branch --list 'agent/codex/add-openspec-and-provider-icons-2026-04-23-16-49'` and `git branch -r --list 'origin/agent/codex/add-openspec-and-provider-icons-2026-04-23-16-49'` returned no refs after `git fetch --prune origin`; `git worktree list --porcelain` no longer shows `agent__codex__add-openspec-and-provider-icons-2026-04-23-16-49`.

BLOCKED: none.
20 changes: 20 additions & 0 deletions ...ec/changes/agent-codex-record-pr-380-cleanup-evidence-2026-04-23-16-54/notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# agent-codex-record-pr-380-cleanup-evidence-2026-04-23-16-54 (minimal / T1)

Branch: `agent/codex/record-pr-380-cleanup-evidence-2026-04-23-16-54`

Backfill truthful cleanup evidence for the merged Active Agents OpenSpec icon lane after `gx branch finish` merged PR `#380` before the change `tasks.md` could record the final PR URL and cleanup proof.

Scope:
- Update `openspec/changes/agent-codex-add-openspec-and-provider-icons-2026-04-23-16-49/tasks.md` only.
- Mark cleanup items complete with exact PR URL, `MERGED` state, merge commit, and post-prune branch/worktree evidence.
- Do not reopen product code or change the shipped extension behavior.

Verification:
- Confirm `gh pr view agent/codex/add-openspec-and-provider-icons-2026-04-23-16-49 --json url,state,mergedAt,mergeCommit`.
- Confirm the lane no longer appears in `git branch --list`, `git branch -r --list`, or `git worktree list --porcelain`.

## Cleanup

- [ ] Run: `gx branch finish --branch agent/codex/record-pr-380-cleanup-evidence-2026-04-23-16-54 --base main --via-pr --wait-for-merge --cleanup`
- [ ] Record PR URL + `MERGED` state in the completion handoff.
- [ ] Confirm sandbox worktree is gone (`git worktree list`, `git branch -a`).