Conversation
Operators already use the Active Agents tree as a runtime control surface, so the session row should reveal the live terminal before it offers lower-value diff navigation. This patch swaps the inline diff action for a terminal action, matches live terminals by session pid when possible, falls back to a worktree terminal when needed, and routes Stop through Ctrl+C before the CLI fallback. Constraint: Active session metadata exposes pid and worktree path but no durable VS Code terminal id Rejected: Keep Open Diff inline | lower operator value than terminal reveal for live task control Confidence: high Scope-risk: narrow Directive: Keep session terminal matching pid-first unless the launcher gains a stable terminal identity field Tested: node --test test/vscode-active-agents-session-state.test.js; openspec validate agent-codex-active-agents-terminal-controls-2026-04-23-17-11 --type change --strict; openspec validate --specs Not-tested: Real VS Code terminal matching against existing interactive terminals outside the mock processId flow
NagyVikt
deleted the
agent/codex/active-agents-terminal-controls-2026-04-23-17-11
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).