Skip to content

Keep merged cleanup evidence truthful #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NagyVikt wants to merge 1 commit into from
Closed

Keep merged cleanup evidence truthful #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...spec/changes/agent-codex-dismiss-stale-active-session-2026-04-23-18-29/notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

Branch: `agent/codex/dismiss-stale-active-session-2026-04-23-18-29`

Describe the change in a sentence or two. Commit message is the spec of record.
Add a separate `Dismiss` action for stale or dead Active Agents rows so operators can clear leftover active-session records after usage-limit exits or manual takeovers.
Keep the live `Stop` flow process-oriented for real terminals and pids, while verifying the new dismiss path with the focused extension test suite.

## Handoff

Expand All @@ -12,6 +13,7 @@ Describe the change in a sentence or two. Commit message is the spec of record.

## Cleanup

- [ ] Run: `gx branch finish --branch agent/codex/dismiss-stale-active-session-2026-04-23-18-29 --base main --via-pr --wait-for-merge --cleanup`
- [ ] Record PR URL + `MERGED` state in the completion handoff.
- [ ] Confirm sandbox worktree is gone (`git worktree list`, `git branch -a`).
- Cleanup result: PR [#393](https://github.com/recodeee/gitguardex/pull/393) is `MERGED` with merge commit `fad45e8daed2be67ec8d88b0cebe1ff5040e73f4`; `gh pr view 393`, `git worktree list`, and `git branch -a` on `main` show the lane is closed and pruned.
- [x] Run: `gx branch finish --branch agent/codex/dismiss-stale-active-session-2026-04-23-18-29 --base main --via-pr --wait-for-merge --cleanup`
- [x] Record PR URL + `MERGED` state in the completion handoff.
- [x] Confirm sandbox worktree is gone (`git worktree list`, `git branch -a`).
7 changes: 4 additions & 3 deletions ...c/changes/agent-codex-harden-scorecard-best-practices-2026-04-23-18-42/tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ This change is complete only when **all** of the following are true:

## 4. Cleanup (mandatory; run before claiming completion)

- [ ] 4.1 Run the cleanup pipeline: `gx branch finish --branch agent/codex/harden-scorecard-best-practices-2026-04-23-18-42 --base main --via-pr --wait-for-merge --cleanup`. This handles commit -> push -> PR create -> merge wait -> worktree prune in one invocation.
- [ ] 4.2 Record the PR URL and final merge state (`MERGED`) in the completion handoff.
- [ ] 4.3 Confirm the sandbox worktree is gone (`git worktree list` no longer shows the agent path; `git branch -a` shows no surviving local/remote refs for the branch).
- Cleanup result: PR [#392](https://github.com/recodeee/gitguardex/pull/392) is `MERGED` with merge commit `f0ee72a10b676508e21def6bc9a953522d80da22`; `gh pr view 392`, `git worktree list`, and `git branch -a` on `main` show the lane is closed and pruned.
- [x] 4.1 Run the cleanup pipeline: `gx branch finish --branch agent/codex/harden-scorecard-best-practices-2026-04-23-18-42 --base main --via-pr --wait-for-merge --cleanup`. This handles commit -> push -> PR create -> merge wait -> worktree prune in one invocation.
- [x] 4.2 Record the PR URL and final merge state (`MERGED`) in the completion handoff.
- [x] 4.3 Confirm the sandbox worktree is gone (`git worktree list` no longer shows the agent path; `git branch -a` shows no surviving local/remote refs for the branch).
Loading