Conversation
…sn't claim the worktree is on disk
The old message read "Branch cleanup skipped for now." That sounded like
a present-tense fact ("worktree still here"), but in practice the
autofinish watcher (or `gx worktree prune --include-pr-merged`) prunes
the worktree shortly after the PR merges — so the worktree may be
*gone* by the time the agent reads the line.
The new message:
PR pending review/check policy. Worktree retained for now; the
autofinish watcher (or 'gx worktree prune --include-pr-merged
--delete-branches') will prune it after merge. Verify with
'git worktree list' before claiming the worktree is still on disk.
Why: agents (Claude in particular) were reading "skipped for now" as
proof of presence and recommending a follow-up `gx branch finish ...
--cleanup` to users whose worktree had already been pruned — confusing
output and wasted turns.
Updates the matching regex in `src/doctor/index.js#doctorFinishFlowIsPending`
to anchor on "PR pending review/check policy." so doctor still
recognises this state. The same string lives in
`templates/scripts/agent-branch-finish.sh` (the canonical script
templated into managed repos) and is updated alongside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).