Skip to content

Stabilize self-update verification when child-process spawn is unavailable #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagyVikt merged 1 commit into from
Apr 12, 2026
Merged

Stabilize self-update verification when child-process spawn is unavailable #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/install.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,24 @@ function extractCreatedWorktree(output) {
return match[1].trim();
}

const spawnProbe = cp.spawnSync(process.execPath, ['-e', 'process.exit(0)'], { encoding: 'utf8' });
const canSpawnChildProcesses = !spawnProbe.error && spawnProbe.status === 0;
const spawnUnavailableReason = spawnProbe.error
? `${spawnProbe.error.code || 'unknown'}: ${spawnProbe.error.message}`
: `status=${spawnProbe.status}`;

if (!canSpawnChildProcesses) {
test('self-update prompt requires explicit y/n when approval is not preconfigured', () => {
const source = fs.readFileSync(cliPath, 'utf8');
assert.match(
source,
/const shouldUpdate = interactive\s*\?\s*promptYesNoStrict\(\s*`Update now\?\s*\(\$\{NPM_BIN\} i -g \$\{packageJson\.name\}@latest\)`\s*,?\s*\)\s*:\s*autoApproval;/s,
);
});

test('install integration suite requires child_process spawnSync support', { skip: `spawn unavailable (${spawnUnavailableReason})` }, () => {});
} else {

test('setup provisions workflow files and repo config', () => {
const repoDir = initRepo();

Expand Down Expand Up @@ -1833,3 +1851,5 @@ test('unknown command suggests nearest valid command', () => {
assert.equal(result.status, 1);
assert.match(result.stderr, /Did you mean 'release'\?/);
});

}
Loading