Merged
Conversation
Add a configuration flag to allow duplicate IDs when loading VCR cassettes. This addresses scenarios where implementers need to load cassettes with duplicate IDs without breaking the API. Changes: - Added `allowDuplicateIDs` boolean field to TestServer struct - Added `AllowDuplicateIDs(bool)` method to enable/disable the flag - Updated duplicate ID validation in vcr.go to respect the flag - When flag is enabled, duplicate entries are skipped (existing preserved) - Added comprehensive test coverage for the new functionality - Updated Reset() to clear the flag When AllowDuplicateIDs is set to true, loading VCR cassettes with duplicate bot/deal IDs will not return an error. Instead, duplicate entries are silently skipped, preserving the existing entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a configuration flag to allow duplicate IDs when loading VCR cassettes. This addresses scenarios where implementers need to load cassettes with duplicate IDs without breaking the API.
Changes:
allowDuplicateIDsboolean field to TestServer structAllowDuplicateIDs(bool)method to enable/disable the flagWhen AllowDuplicateIDs is set to true, loading VCR cassettes with duplicate bot/deal IDs will not return an error. Instead, duplicate entries are silently skipped, preserving the existing entries.