Skip to content

agent: @U0AJM7X8FBR API - formatter github action. • actual: formatter is only #310

Open
sweetmantech wants to merge 1 commit intotestfrom
agent/-u0ajm7x8fbr-api---formatter-g-1773777819028
Open

agent: @U0AJM7X8FBR API - formatter github action. • actual: formatter is only #310
sweetmantech wants to merge 1 commit intotestfrom
agent/-u0ajm7x8fbr-api---formatter-g-1773777819028

Conversation

@sweetmantech
Copy link
Copy Markdown
Contributor

Automated PR from coding agent.

Prompt: @U0AJM7X8FBR API - formatter github action.
• actual: formatter is only run manually.
• required: formatter is run automatically in a github action on all pull requests so all code changes follow standardized formatting.

Adds a new `format.yml` workflow that runs `pnpm format:check` (Prettier)
automatically on every pull request targeting `main` or `test`, ensuring
all code changes follow standardized formatting before merge.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
recoup-api Ready Ready Preview Mar 17, 2026 8:07pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .github/workflows/format.yml is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c956872d-a06e-4ed6-9ab6-648cbf202d1f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/-u0ajm7x8fbr-api---formatter-g-1773777819028
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@recoup-coding-agent recoup-coding-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: API formatter GitHub Action

Summary

Adds a GitHub Actions workflow (.github/workflows/format.yml) that runs pnpm format:check on all PRs targeting main and test. Ensures code formatting is enforced automatically on every PR.

Assessment

✅ Simple, correct CI addition.
✅ Uses pinned action versions (actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4).
✅ Only one job, one responsibility.

🔵 Nits

  1. Recommend caching the pnpm store for faster CI runs:
- name: Get pnpm store directory
  id: pnpm-cache
  run: echo "dir=$(pnpm store path)" >> $GITHUB_OUTPUT

- uses: actions/cache@v4
  with:
    path: ${{ steps.pnpm-cache.outputs.dir }}
    key: pnpm-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
    restore-keys: pnpm-${{ runner.os }}-
  1. Consider adding --frozen-lockfile to pnpm install to catch lockfile drift in CI.

Verdict: approve

Straightforward CI improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants