agent: @U0AJM7X8FBR current: composio connections for limited tools. Expected: all major composio connections#337
Open
sweetmantech wants to merge 1 commit intotestfrom
Open
Conversation
… productivity platforms Adds Spotify, Instagram, Twitter/X, YouTube, Gmail, Google Calendar, Slack, and LinkedIn as supported connectors. Artist connections now allow Spotify, Instagram, Twitter, and YouTube in addition to TikTok. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe pull request expands the supported connectors across the Composio integration layer by adding eight new toolkit integrations (gmail, googlecalendar, spotify, instagram, twitter, youtube, slack, linkedin) to the existing four (googlesheets, googledrive, googledocs, tiktok). Display names and artist connector filtering are updated accordingly to reflect the broader toolkit support. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
lib/composio/connectors/getConnectors.ts (1)
18-31: Centralize connector definitions to avoid cross-file slug drift.These slugs are now duplicated across multiple files (toolkits list, display names, artist allowlist). A single shared connector registry would reduce update risk and keep behavior consistent.
💡 Refactor direction (shared source of truth)
+// Example shape in a shared module (e.g. lib/composio/connectors/catalog.ts) +export const CONNECTOR_CATALOG = { + googlesheets: { displayName: "Google Sheets", artistAllowed: false }, + googledrive: { displayName: "Google Drive", artistAllowed: false }, + googledocs: { displayName: "Google Docs", artistAllowed: false }, + gmail: { displayName: "Gmail", artistAllowed: false }, + googlecalendar: { displayName: "Google Calendar", artistAllowed: false }, + tiktok: { displayName: "TikTok", artistAllowed: true }, + spotify: { displayName: "Spotify", artistAllowed: true }, + instagram: { displayName: "Instagram", artistAllowed: true }, + twitter: { displayName: "Twitter / X", artistAllowed: true }, + youtube: { displayName: "YouTube", artistAllowed: true }, + slack: { displayName: "Slack", artistAllowed: false }, + linkedin: { displayName: "LinkedIn", artistAllowed: false }, +} as const;-const SUPPORTED_TOOLKITS = [ ... ]; +const SUPPORTED_TOOLKITS = Object.keys(CONNECTOR_CATALOG);As per coding guidelines, "Extract shared logic into reusable utilities following Don't Repeat Yourself (DRY) principle".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@lib/composio/connectors/getConnectors.ts` around lines 18 - 31, The SUPPORTED_TOOLKITS constant duplicates connector slugs across the codebase and should be centralized; create a single shared connector registry utility (e.g., export a CONNECTORS object or array from a new module) that defines canonical slugs, displayName, and any allowlist/metadata, replace the local SUPPORTED_TOOLKITS usage with an import from that registry, and update other files (toolkits list, display names, artist allowlist) to consume the shared registry so slugs and metadata remain single source of truth (look for references to SUPPORTED_TOOLKITS and any display name or allowlist variables to update).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/composio/connectors/isAllowedArtistConnector.ts`:
- Line 5: The exported constant ALLOWED_ARTIST_CONNECTORS is failing Prettier;
reformat its array literal to satisfy the formatter by breaking the items onto
separate lines and adding trailing comma(s) (e.g., each connector string on its
own line inside the array) while preserving the export and the as const
assertion so the symbol ALLOWED_ARTIST_CONNECTORS remains unchanged.
---
Nitpick comments:
In `@lib/composio/connectors/getConnectors.ts`:
- Around line 18-31: The SUPPORTED_TOOLKITS constant duplicates connector slugs
across the codebase and should be centralized; create a single shared connector
registry utility (e.g., export a CONNECTORS object or array from a new module)
that defines canonical slugs, displayName, and any allowlist/metadata, replace
the local SUPPORTED_TOOLKITS usage with an import from that registry, and update
other files (toolkits list, display names, artist allowlist) to consume the
shared registry so slugs and metadata remain single source of truth (look for
references to SUPPORTED_TOOLKITS and any display name or allowlist variables to
update).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8d352f9c-777b-4a52-a07f-e1ca78d2eb1f
⛔ Files ignored due to path filters (3)
lib/composio/connectors/__tests__/getConnectors.test.tsis excluded by!**/*.test.*,!**/__tests__/**and included bylib/**lib/composio/connectors/__tests__/getConnectorsHandler.test.tsis excluded by!**/*.test.*,!**/__tests__/**and included bylib/**lib/composio/connectors/__tests__/isAllowedArtistConnector.test.tsis excluded by!**/*.test.*,!**/__tests__/**and included bylib/**
📒 Files selected for processing (3)
lib/composio/connectors/getConnectors.tslib/composio/connectors/getConnectorsHandler.tslib/composio/connectors/isAllowedArtistConnector.ts
| * Only these connectors will be shown in the artist-connectors API. | ||
| */ | ||
| export const ALLOWED_ARTIST_CONNECTORS = ["tiktok"] as const; | ||
| export const ALLOWED_ARTIST_CONNECTORS = ["tiktok", "spotify", "instagram", "twitter", "youtube"] as const; |
There was a problem hiding this comment.
Fix formatting here to unblock CI.
This line is likely tripping the reported Prettier check; reformatting the array should clear the pipeline failure.
💡 Suggested formatting change
-export const ALLOWED_ARTIST_CONNECTORS = ["tiktok", "spotify", "instagram", "twitter", "youtube"] as const;
+export const ALLOWED_ARTIST_CONNECTORS = [
+ "tiktok",
+ "spotify",
+ "instagram",
+ "twitter",
+ "youtube",
+] as const;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@lib/composio/connectors/isAllowedArtistConnector.ts` at line 5, The exported
constant ALLOWED_ARTIST_CONNECTORS is failing Prettier; reformat its array
literal to satisfy the formatter by breaking the items onto separate lines and
adding trailing comma(s) (e.g., each connector string on its own line inside the
array) while preserving the export and the as const assertion so the symbol
ALLOWED_ARTIST_CONNECTORS remains unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR from coding agent.
Prompt: @U0AJM7X8FBR current: composio connections for limited tools. Expected: all major composio connections.Please review how composio currently connects and works and then add more tools that are important.
Changes:
New connectors added:
Summary by CodeRabbit