-
Notifications
You must be signed in to change notification settings - Fork 13
feat: migrate room segment lookup to dedicated chats api #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+44
−61
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,29 @@ | ||
| import { useQuery } from "@tanstack/react-query"; | ||
| import { usePrivy } from "@privy-io/react-auth"; | ||
| import { useApiOverride } from "@/hooks/useApiOverride"; | ||
| import { getChatSegment } from "@/lib/chats/getChatSegment"; | ||
|
|
||
| interface RoomSegmentResponse { | ||
| segmentId: string | null; | ||
| error?: string; | ||
| } | ||
|
|
||
| export const useChatSegment = (roomId?: string) => { | ||
| const { getAccessToken } = usePrivy(); | ||
| const apiOverride = useApiOverride(); | ||
|
|
||
| return useQuery({ | ||
| queryKey: ["roomSegment", roomId], | ||
| queryFn: async (): Promise<RoomSegmentResponse> => { | ||
| if (!roomId) { | ||
| return { segmentId: null }; | ||
| } | ||
| if (!roomId) return { segmentId: null }; | ||
|
|
||
| const response = await fetch(`/api/roomSegment?roomId=${roomId}`); | ||
| if (!response.ok) { | ||
| const error = await response.json(); | ||
| console.error("[useChatSegment] API error:", { | ||
| status: response.status, | ||
| error, | ||
| }); | ||
| throw new Error(error.error || "Failed to fetch segment ID"); | ||
| } | ||
| const accessToken = await getAccessToken(); | ||
| if (!accessToken) throw new Error("No access token"); | ||
|
|
||
| const data = await response.json(); | ||
| return data; | ||
| const data = await getChatSegment(roomId, accessToken, apiOverride ?? undefined); | ||
| return { segmentId: data.segment_id ?? null }; | ||
| }, | ||
| enabled: !!roomId, | ||
| staleTime: 1000 * 60 * 5, // Cache for 5 minutes | ||
| staleTime: 1000 * 60 * 5, | ||
| retry: 2, | ||
| }); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { NEW_API_BASE_URL } from "@/lib/consts"; | ||
|
|
||
| interface ChatSegmentResponse { | ||
| status: string; | ||
| room_id: string; | ||
| segment_id: string | null; | ||
| segment_exists: boolean; | ||
| } | ||
|
|
||
| /** | ||
| * Fetches the segment associated with a chat room. | ||
| */ | ||
| export async function getChatSegment( | ||
| roomId: string, | ||
| accessToken: string, | ||
| baseUrl?: string, | ||
| ): Promise<ChatSegmentResponse> { | ||
| const url = baseUrl || NEW_API_BASE_URL; | ||
|
|
||
| const response = await fetch(`${url}/api/chats/${encodeURIComponent(roomId)}/segment`, { | ||
| headers: { | ||
| Authorization: `Bearer ${accessToken}`, | ||
| }, | ||
| }); | ||
|
|
||
| if (!response.ok) { | ||
| const error = await response.json(); | ||
| throw new Error(error.error || "Failed to fetch segment ID"); | ||
| } | ||
|
|
||
| return response.json(); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The query function now depends on both
accessTokenandbaseUrl, but the cache key only includesroomId. In React Query, if the user logs out/in in the same tab (or changes?api=override) whileroomIdstays constant, the hook can reuse cached data for up to the 5-minutestaleTimeand skip refetching, which can show segment data fetched under a different auth/backend context. Add auth/backend scope to the key (or invalidate on token/base URL changes) so cached results cannot bleed across sessions/environments.Useful? React with 👍 / 👎.