Increase PHPStan level to 6

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-  level: 5
+  level: 6
   paths:
     - src
     - tests
@@ -9,6 +9,7 @@ parameters:
     - '#is_callable.*recruiter_#'
     - '#recruiter_became_master#'
     - '#recruiter_stept_back#'
-    - '#afterSuccess.*0 required#'
     - '#Unsafe usage of new static\(\).#'
+    - '#Call to an undefined method.*FactoryMethodCommand::#'
   inferPrivatePropertyTypeFromConstructor: true
+  treatPhpDocTypesAsCertain: false

src/Recruiter/Cleaner.php

@@ -14,14 +14,14 @@ public function __construct(private readonly Repository $repository)
     {
     }
 
-    public function cleanArchived(Interval $gracePeriod)
+    public function cleanArchived(Interval $gracePeriod): int
     {
         $upperLimit = T\now()->before($gracePeriod);
 
         return $this->repository->cleanArchived($upperLimit);
     }
 
-    public function cleanScheduled(?Interval $gracePeriod = null)
+    public function cleanScheduled(?Interval $gracePeriod = null): int
     {
         $upperLimit = T\now();
         if (!is_null($gracePeriod)) {
@@ -31,7 +31,7 @@ public function cleanScheduled(?Interval $gracePeriod = null)
         return $this->repository->cleanScheduled($upperLimit);
     }
 
-    public function bye()
+    public function bye(): void
     {
     }
 }

src/Recruiter/Factory.php

@@ -11,6 +11,9 @@
 
 class Factory
 {
+    /**
+     * @param array<string, mixed> $options
+     */
     public function getMongoDb(URI $uri, array $options = []): Database
     {
         try {

src/Recruiter/Infrastructure/Command/Bko/AnalyticsCommand.php

@@ -45,11 +45,12 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        /** @var string */
+        /** @var string $target */
         $target = $input->getOption('target');
         $db = $this->factory->getMongoDb(MongoURI::from($target));
         $recruiter = new Recruiter($db);
 
+        /** @var ?string $group */
         $group = $input->getOption('group');
         $analytics = $recruiter->analytics($group);
 
@@ -77,6 +78,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         return self::SUCCESS;
     }
 
+    /**
+     * @param array{
+     *     jobs: array{queued: int, postponed: int, zombies: int},
+     *     throughput: array{value: float, value_per_second: float},
+     *     latency: array{average: float},
+     *     execution_time: array{average: float}
+     * } $analytics
+     */
     private function calculateColumnsWidth(array $analytics): int
     {
         $maxColumns = 1;

src/Recruiter/Infrastructure/Command/Bko/RemoveSchedulerCommand.php

@@ -20,17 +20,14 @@
 
 class RemoveSchedulerCommand extends Command
 {
-    /**
-     * @var SchedulerRepository
-     */
-    private $schedulerRepository;
+    private SchedulerRepository $schedulerRepository;
 
     public function __construct(private readonly Factory $factory, private readonly LoggerInterface $logger)
     {
         parent::__construct();
     }
 
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('scheduler:remove')
@@ -45,9 +42,9 @@ protected function configure()
         ;
     }
 
-    protected function initialize(InputInterface $input, OutputInterface $output)
+    protected function initialize(InputInterface $input, OutputInterface $output): void
     {
-        /** @var string */
+        /** @var string $target */
         $target = $input->getOption('target');
         $db = $this->factory->getMongoDb(MongoURI::from($target));
         $this->schedulerRepository = new SchedulerRepository($db);
@@ -75,7 +72,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         return self::SUCCESS;
     }
 
-    private function selectUrnToDelete(array $urns, InputInterface $input, OutputInterface $output)
+    /**
+     * @param string[] $urns
+     */
+    private function selectUrnToDelete(array $urns, InputInterface $input, OutputInterface $output): string|false
     {
         /** @var QuestionHelper $helper */
         $helper = $this->getHelper('question');
@@ -96,6 +96,9 @@ private function selectUrnToDelete(array $urns, InputInterface $input, OutputInt
         return $selectedUrn;
     }
 
+    /**
+     * @param array<array<string, string>> $data
+     */
     private function printTable(array $data, OutputInterface $output): void
     {
         $rows = [];
@@ -114,6 +117,9 @@ private function printTable(array $data, OutputInterface $output): void
         echo PHP_EOL;
     }
 
+    /**
+     * @return ?array<array<string, string>>
+     */
     protected function buildOutputData(): ?array
     {
         $outputData = [];

src/Recruiter/Infrastructure/Command/RecruiterCommand.php

@@ -18,6 +18,7 @@
 use Recruiter\Geezer\Timing\WaitStrategy;
 use Recruiter\Infrastructure\Filesystem\BootstrapFile;
 use Recruiter\Infrastructure\Memory\MemoryLimit;
+use Recruiter\Infrastructure\Memory\MemoryLimitExceededException;
 use Recruiter\Infrastructure\Persistence\Mongodb\URI as MongoURI;
 use Recruiter\Recruiter;
 use Symfony\Component\Console\Input\InputDefinition;
@@ -42,6 +43,9 @@ public static function toRobustCommand(Factory $factory, LoggerInterface $logger
         return new RobustCommandRunner(new static($factory, $logger), $logger);
     }
 
+    /**
+     * @throws MemoryLimitExceededException
+     */
     public function execute(): bool
     {
         $this->rollbackLockedJobs();
@@ -62,6 +66,11 @@ private function rollbackLockedJobs(): void
         $this->log(sprintf('rolled back %d jobs in %fms', $rolledBack, ($rollbackEndAt - $rollbackStartAt) * 1000), $logLevel);
     }
 
+    /**
+     * @return array<string, string>
+     *
+     * @throws MemoryLimitExceededException
+     */
     private function assignJobsToWorkers(): array
     {
         $pickStartAt = microtime(true);
@@ -182,7 +191,7 @@ public function init(InputInterface $input): void
         $this->recruiter->createCollectionsAndIndexes();
 
         if ($input->getOption('bootstrap')) {
-            /** @var string */
+            /** @var string $bootstrap */
             $bootstrap = $input->getOption('bootstrap');
             BootstrapFile::fromFilePath($bootstrap)->load($this->recruiter);
         }

src/Recruiter/Infrastructure/Filesystem/BootstrapFile.php

@@ -21,9 +21,9 @@ public static function fromFilePath(string $filePath): self
         return new static($filePath);
     }
 
-    public function load(Recruiter $recruiter)
+    public function load(Recruiter $recruiter): void
     {
-        return require $this->filePath;
+        require $this->filePath;
     }
 
     private function validate(string $filePath): void

src/Recruiter/Infrastructure/Memory/MemoryLimit.php

@@ -18,7 +18,7 @@ public function __construct(int|string|System $limit)
         try {
             $this->limit = box($limit);
         } catch (ParseException $e) {
-            throw new \UnexpectedValueException(sprintf("Memory limit '%s' is an invalid value: %s", $limit, $e->getMessage()));
+            throw new \UnexpectedValueException(sprintf("Memory limit '%s' is an invalid value: %s", (string) $limit, $e->getMessage()));
         }
     }