Event form implementation#224
Open
mashhoodr wants to merge 7 commits intorecurship:masterfrom
Open
Conversation
-cleanup -refactor
mashhoodr
commented
Nov 22, 2018
| path="/events/:event_id" | ||
| render={routeProps => ( | ||
| <div> | ||
| {props.userState.token ? ( |
Member
Author
There was a problem hiding this comment.
@Sarmad93 we can access the event detail page without logging in. But when we click the button we need to redirect to the login page if we are not logged in
There was a problem hiding this comment.
Alright got it! will fix this one later tonight.
Member
Author
|
@saadullahaleem @Sarmad93 is having some issue submitting to the endpoint for forms submissions, its returning 500. Can you please have a quick look on that? |
|
@mashhoodr i think this one is ready for the final review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.