wasm compatibility: switch from std:time to chrono crate#1
Open
anotherstarburst wants to merge 2 commits intoredasgard:mainfrom
Open
wasm compatibility: switch from std:time to chrono crate#1anotherstarburst wants to merge 2 commits intoredasgard:mainfrom
anotherstarburst wants to merge 2 commits intoredasgard:mainfrom
Conversation
- Update all remaining security@asgardtech.com to security@redasgard.com - Ensure consistent security contact information across all files
- Adds chrono as a dependency with wasmbind and serde features. - Replaces use of std::time for validation_timestamp with chrono::Utc::now().timestamp(). - Makes this lib wasm-compatible Add validation timestamp test for ValidationEngine
212fad2 to
2631943
Compare
Author
|
Note, I did run per the contribution requirements, but the project doesn't pass even before this PR. I've made sure my changes pass fine - but didn't want to bloat the PR with a bunch of other changes that fix the pre-existing issue :) |
340c5aa to
c13c9d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
A clear and concise description of what this PR does.
The crate was failing on my wasm-application due to std::time not being supported. I've switched out std::time to use chrono instead to be cross-compatible with more environments.
Type of Change
Related Issues
Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)
Changes Made
Code Quality
Testing
Test Coverage
Security Considerations
Security Testing
Documentation
Breaking Changes
Performance Impact
Checklist
(fun fact - this duplicates some of the checklist items from above...)
Additional Notes
Any additional information that reviewers should know.
Screenshots (if applicable)
Add screenshots to help explain your changes.
Reviewer Notes
Any specific areas you'd like reviewers to focus on or questions you have.