Skip to content

Commit aa4cded

Browse files
committed
add comments to tests
1 parent 64089dc commit aa4cded

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tests/decider_tests.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -972,7 +972,7 @@ def test_get_all_variants_without_expose_with_hg(self):
972972
experiment_name="hg", variant="holdout", event_fields=event_fields
973973
)
974974

975-
def test_get_all_variants_without_expose_ctx_missing_bucketing_key_exception(self):
975+
def test_get_all_variants_without_expose_ctx_missing_device_id(self):
976976
# no device_id in ctx
977977
dc = DeciderContext(user_id=USER_ID)
978978

@@ -988,6 +988,8 @@ def test_get_all_variants_without_expose_ctx_missing_bucketing_key_exception(sel
988988

989989
decision_arr = decider.get_all_variants_without_expose()
990990

991+
# device_id experiment not bucketed since
992+
# device_id is missing in ctx
991993
self.assertEqual(len(decision_arr), 2)
992994

993995
self.assertEqual(
@@ -1226,6 +1228,7 @@ def test_get_all_variants_for_identifier_without_expose_canonical_url(self):
12261228
identifier=identifier, identifier_type=bucket_val
12271229
)
12281230

1231+
# non-canonical_url experiment is not included in result
12291232
self.assertEqual(len(variant_arr), 2)
12301233
self.assertEqual(
12311234
first_occurrence_of_key_in(variant_arr, "experimentName", "exp_1"),

0 commit comments

Comments
 (0)