-
Notifications
You must be signed in to change notification settings - Fork 308
Use server-side apply in Grafana Application #8300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In PR #7426, an attempt was made to deploy updated Grafana dashboard. This update started failing the Grafana Application deployment via the CI system. Upon investigation of ArgoCD within the CI cluster, this error message was found: ConfigMap controllers-overview-dc566k7t25 is invalid: metadata.annotations: Too long: must have at most 262144 bytes. Retrying attempt #28 at 3:06PM. Investigation of ArgoCD documentation shows that using the ServerSideApply option should fix issues such as this. While there is an option for users to apply this label on per-resource level, it would require us to investigate every time the CI would fail because of this. So instead, let's set ServerSideApply on the whole application to fix any future dashboard issues.
🤖 Gemini AI Assistant AvailableHi @kubasikus! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
🤖 Hi @kubasikus, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
@gemini-cli /review |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hugares, kubasikus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kubasikus: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In PR #7426, an attempt was made to deploy updated Grafana dashboard. This update started failing the Grafana Application deployment via the CI system. Upon investigation of ArgoCD within the CI cluster, this error message was found: ConfigMap controllers-overview-dc566k7t25 is invalid: metadata.annotations: Too long: must have at most 262144 bytes. Retrying attempt #28 at 3:06PM.
Investigation of ArgoCD documentation shows that using the ServerSideApply option should fix issues such as this. While there is an option for users to apply this label on per-resource level, it would require us to investigate every time the CI would fail because of this. So instead, let's set ServerSideApply on the whole application to fix any future dashboard issues.