Add a new requirements for PR to checklist#113
Open
yulisuliman wants to merge 4 commits intoredhat-beyond:mainfrom
Open
Add a new requirements for PR to checklist#113yulisuliman wants to merge 4 commits intoredhat-beyond:mainfrom
yulisuliman wants to merge 4 commits intoredhat-beyond:mainfrom
Conversation
yulisuliman
force-pushed
the
edit-checklist
branch
from
dcea1f3 to
13c17b2
Compare
yulisuliman
force-pushed
the
edit-checklist
branch
from
13c17b2 to
90fa159
Compare
Adding checklist to fill when commiting.
Adding a section to avoid using Django default models name
Change line 22 from: `Above each test should have a comment that describes what the test is meant for.` to `Each test should have a comment above it to describe the test's purpose.`
yulisuliman
force-pushed
the
edit-checklist
branch
from
90fa159 to
dba8379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #114
Dependant on #82