Fixes to Shipwright Build Strategy#67
Merged
cmoulliard merged 2 commits intoredhat-buildpacks:mainfrom May 20, 2025
Merged
Conversation
Use the ubi-minimal image for running pure bash commands. This avoids pulling additional images from Docker Hub, which requires a pull secret to be configured. Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
Use overridable volumes in the cluster build strategy for buildpacks. This ensures the build strategy works "out of the box", and does not require additional configuration from developers to execute. Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
adambkaplan
force-pushed
the
use-ubi-images
branch
from
316358c to
9599c88
Compare
cmoulliard
approved these changes
May 20, 2025
Contributor
|
LGTM. Can be merged ? @adambkaplan |
Contributor
Author
|
This should be mergeable - the Java buildpacks client issue appears unrelated to my change. |
Contributor
Author
|
Noted - we wouldn't need to in-line the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emptyDirand overridable by default.