Improve rbd keyring tests for cinder and glance#71
Improve rbd keyring tests for cinder and glance#71cedlecomte wants to merge 2 commits intoredhat-cip:masterfrom
Conversation
|
👍 looks good ! Didn't look, but are there the same tests for the glance keyring and for the keyrings on the compute nodes ? |
|
before merging, I'm waiting for the same in hypervisor ;-) |
We had a check on the file's permissions and the way we manage the rbd detection. Co-Authored-By: Dimitri Savineau <dimitri.savineau@enovance.com>
cedlecomte
changed the title
|
I added the glance tests like @fcharlier asked. Tell me if it's not enough. |
|
👍 |
spec/tests/image/image_spec.rb
Outdated
There was a problem hiding this comment.
I think this REGEX is dangerous. I deployed SpinalStack on the CI and I have:
default_store=rbd
There was a problem hiding this comment.
Something like that : "^default_store *= *rbd" will be convenient for you ?
There was a problem hiding this comment.
@Prophidys more like default_store\s*=\s*rbd\s*$ to allow other kinds of spaces for space-ish 🚀 people 👾
cedlecomte
force-pushed
the
master
branch
2 times, most recently
from
fb9d444 to
8f159db
Compare
There was a problem hiding this comment.
Just to be sure the parameter isn't empty, could you use ^rbd_user\s*=\s*\S+
|
👍 @EmilienM 's query seems to have been implemented |
3 participants
We had a check on the file's permissions and the way we manage the rbd
detection.
Co-Authored-By: Dimitri Savineau dimitri.savineau@enovance.com