Skip to content

Restart all metrics on config change#643

Open
vitus133 wants to merge 1 commit intoredhat-cne:mainfrom
vitus133:cep-restart-main
Open

Restart all metrics on config change#643
vitus133 wants to merge 1 commit intoredhat-cne:mainfrom
vitus133:cep-restart-main

Conversation

@vitus133
Copy link
Member

This commit adds an explicit cloud-event-proxy (CEP) sidecar restart on the daemon's command. The command is send after any reconfiguration. Upon this command, the sidecar exec's itself and re-reads all the configurations. This eliminates the need for incremental and selective metric cleanup that has proven complex and error-prone.

/cc @jzding @lack @josephdrichard @nocturnalastro @greyerof @edcdavid

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from edcdavid, jzding and lack February 19, 2026 08:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

@vitus133: GitHub didn't allow me to request PR reviews from the following users: greyerof.

Note that only redhat-cne members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

This commit adds an explicit cloud-event-proxy (CEP) sidecar restart on the daemon's command. The command is send after any reconfiguration. Upon this command, the sidecar exec's itself and re-reads all the configurations. This eliminates the need for incremental and selective metric cleanup that has proven complex and error-prone.

/cc @jzding @lack @josephdrichard @nocturnalastro @greyerof @edcdavid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vitus133 vitus133 marked this pull request as ready for review February 19, 2026 08:46
This commit adds an explicit cloud-event-proxy (CEP) sidecar restart on the daemon's command. The command is send after any reconfiguration. Upon this command, the sidecar exec's itself and re-reads all the configurations. This eliminates the need for incremental and selective metric cleanup that has proven complex and error-prone.

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@vitus133 vitus133 changed the title Restart on all metrics config change Restart all metrics on config change Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant