Restart all metrics on config change#643
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vitus133 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vitus133: GitHub didn't allow me to request PR reviews from the following users: greyerof. Note that only redhat-cne members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This commit adds an explicit cloud-event-proxy (CEP) sidecar restart on the daemon's command. The command is send after any reconfiguration. Upon this command, the sidecar exec's itself and re-reads all the configurations. This eliminates the need for incremental and selective metric cleanup that has proven complex and error-prone. Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
158e0d2 to
f45eac2
Compare
This commit adds an explicit cloud-event-proxy (CEP) sidecar restart on the daemon's command. The command is send after any reconfiguration. Upon this command, the sidecar exec's itself and re-reads all the configurations. This eliminates the need for incremental and selective metric cleanup that has proven complex and error-prone.
/cc @jzding @lack @josephdrichard @nocturnalastro @greyerof @edcdavid