AWS Service Quotas Exporter Deployment #39
Open
jfilipcz wants to merge 4 commits intoredhat-cop:masterfrom
Open
AWS Service Quotas Exporter Deployment #39jfilipcz wants to merge 4 commits intoredhat-cop:masterfrom
jfilipcz wants to merge 4 commits intoredhat-cop:masterfrom
Conversation
oybed
requested changes
Jul 8, 2021
Contributor
There was a problem hiding this comment.
Comments inline.
One general comment/question - what happens if the API calls are failing to obtain data for awhile - i.e.: it has valid data, then they are failing for a day or two, will the monitoring catch this - or just return old / stale data?
jfilipcz
force-pushed
the
aws_sq_exporter
branch
from
3d5a37e to
abfbdc7
Compare
* Automation update to handle AWS-SQ-Exporter
jfilipcz
force-pushed
the
aws_sq_exporter
branch
from
abfbdc7 to
4e3bc74
Compare
jfilipcz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a Ansible role for deployment of AWS Service Quotas Exporter, along with small fixes in other roles.
How should this be tested?
See README
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc.
Please provide link to other PRs that may be related (blocking, resolves, etc. etc.)
People to notify
cc: @redhat-cop/monitoring