introduced conflict resolution for EnvVars already existing in contai…#31
Open
jmozd wants to merge 2 commits intoredhat-cop:masterfrom
Open
introduced conflict resolution for EnvVars already existing in contai…#31jmozd wants to merge 2 commits intoredhat-cop:masterfrom
jmozd wants to merge 2 commits intoredhat-cop:masterfrom
Conversation
…ner: For now hard-coded, existing EnvVars (with same name as EnvVars defined in PodPreset) will not be overwritten. The old behavior caused a container start without *any* EnvVars in such cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduced conflict resolution for EnvVars already existing in container:
For now hard-coded, existing EnvVars (with same name as EnvVars defined in PodPreset) will not be overwritten.
The old behavior caused a container start without any EnvVars in such cases.
The code already contains preparations to use a "resolution strategy" element of the PodPreset. Such an element currently doesn't exist, so the change is hard-coded to retain original values from the container.