Skip to content

updated naming convention #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akhilnittala wants to merge 5 commits into
base: master
Choose a base branch
from
Open

updated naming convention #1026

akhilnittala wants to merge 5 commits into from
+6 −6

Conversation

@akhilnittala
Copy link
Contributor

@akhilnittala akhilnittala commented Dec 4, 2025

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
just change in naming convention
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
GITOPS-7992
Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

@akhilnittala: The label(s) kind/code-refactoring cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
just change in naming convention
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
GITOPS-7992
Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anandf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anandf
anandf previously approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

olivergondza and others added 4 commits December 5, 2025 13:56
@olivergondza @akhilnittala
feat(tests): Add tests for gitops-must-gather (redhat-developer#958)
aa4865a 
* feat(tests): Add tests for gitops-must-gather

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

* feat(tests): validate_running_must_gather.go: permit image override

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

* fix(tests): 1-120_validate_running_must_gather.go: Do not read file to memory + please gosec

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

* chore(test): Static analysis fixes

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

* fix(tests): Suppress checking files not present in older ocp versions

Signed-off-by: Oliver Gondža <ogondza@gmail.com>

---------

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
updated naming convention
617d58f 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
updated naming convention
980d4cf 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala
updated naming convention
870e982 
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala akhilnittala force-pushed the usr/akhil/GITOPS_7992 branch from b29dc52 to 870e982 Compare December 5, 2025 08:27
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025 •
edited
Loading

@akhilnittala: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.19-e2e 7cb2703 link true /test v4.19-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandf anandf anandf left review comments

@chetan-rns chetan-rns Awaiting requested review from chetan-rns

@keithchong keithchong Awaiting requested review from keithchong

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akhilnittala @anandf @olivergondza