[chore] Adding nightly tests against next RHDH tag#180
[chore] Adding nightly tests against next RHDH tag#180OpinionatedHeron wants to merge 31 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Creating Nightly test for RHDH Local
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Updating tests due to failures
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Updating github-script to use correct Node version
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR TypeTests, Enhancement Description
|
| Relevant files | |||
|---|---|---|---|
| Tests |
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||||
Signed-off-by: Leanne Ahern <lahern@redhat.com>
| const topReleaseBranches = branches | ||
| .map(b => b.name) | ||
| .filter(name => /^release-\d+\.\d+$/.test(name)) | ||
| .sort((a, b) => b.localeCompare(a, undefined, { numeric: true })) | ||
| .slice(0, 2); |
There was a problem hiding this comment.
Looks good, but I would have a slight concern regarding this approach. At Feature Freeze, the release branch for the upcoming version is created and needs to be tested.
For example, when FF for 1.10 will be declared, the release-1.10 branch would be created. And IMO we should also include that branch in the nightly workflow so we can catch potential issues on 1.10 before that version is live.
So between FF and GA for 1.10, we should be testing these branches:
- main
- release-1.10 as upcoming supported
- release-1.9 as currently supported
- release-1.8 as still supported but soon to be EOL
It is only after 1.10 is GA that we would be able to remove release-1.8 from the testing matrix.
So how would you handle such scenario?
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
|
/cherry-pick release-1.7 |
|
@OpinionatedHeron: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Leanne Ahern <lahern@redhat.com>
|
/agentic_review |
Code Review by Qodo
1. JS syntax error comment
|
There was a problem hiding this comment.
@OpinionatedHeron Was this the latest run in your fork?
https://github.com/OpinionatedHeron/rhdh-local/actions/runs/24865263077
If so, it looks like there might be some syntax errors..
To make it easier for reviewers, would you mind sharing a link to a successful run (only the nightly workflow) from your fork?
Ah actually, looks like Qodo captured this syntax error ;) See #180 (comment) |
|
Sorry completely missed this, making fixes now. |
Signed-off-by: Leanne Ahern <lahern@redhat.com>
|
Jobs are passing for main, but failing for 1.9, 1.8, and 1.7 because it cannot find the action file without cherry-picking: https://github.com/OpinionatedHeron/rhdh-local/actions/runs/25003559224 |
|
Test Fail reason - Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/home/runner/work/rhdh-local/rhdh-local/.github/actions/rhdh-local-compose-test'. Did you forget to run actions/checkout before running your local action? |
|
/agentic_review |
| # Checkout default branch so .github/actions/* exists (release-* push may not include the composite). | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ github.event.repository.default_branch || 'main' }} |
There was a problem hiding this comment.
| ref: ${{ github.event.repository.default_branch || 'main' }} |
I think this should not be needed on this PR workflow as the default behavior of the checkout action on push and pull_request triggers would be to checkout the right branch.
| ref: ${{ github.event_name == 'schedule' && github.ref_name || format('{0}', | ||
| github.event.repository.default_branch || 'main') }} |
There was a problem hiding this comment.
| ref: ${{ github.event_name == 'schedule' && github.ref_name || format('{0}', | |
| github.event.repository.default_branch || 'main') }} | |
| ref: ${{ matrix.branch }} |
Should checkout the right branch directly IMO, no?
| - uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ inputs.git_ref }} | ||
| fetch-depth: 0 | ||
|
|
There was a problem hiding this comment.
| - uses: actions/checkout@v6 | |
| with: | |
| ref: ${{ inputs.git_ref }} | |
| fetch-depth: 0 | |
No need to re-checkout this again here if the caller of this composite action is already on the right Git ref.
| docker_compose_version: ${{ env.DOCKER_COMPOSE_VERSION }} | ||
| podman_image: ${{ env.PODMAN_IMAGE }} | ||
| corporate_proxy_image: ${{ env.CORPORATE_PROXY_IMAGE }} | ||
| log_level: ${{ vars.ACTIONS_RUNNER_DEBUG == 'true' && 'debug' || 'info' }} |
There was a problem hiding this comment.
To simplify things, I would suggest not exposing these as parameters in the composite action. Right now, they are being set in both nightly and PR workflows to exactly the same values. Instead, I think they can be set directly in the composite action.
|
4 participants
Description
Added a nightly workflow to RHDH Local in order to run tests against the next RHDH tag. Tried to ensure that it would test all release branches, even if new ones are created.
Which issue(s) does this PR fix or relate to
RHIDP-12133
PR acceptance criteria
How to test changes / Special notes to the reviewer
Tested workflow in my own fork, all tests seem to have run as expected but there were some failures for 1.8 and 1.7 - mostly related to arm, so I think they are to be expected.