docs: remove database: ${POSTGRES_DB} env

[Fortune-Ndlovu]

Description

chore(doc): remove database: ${POSTGRES_DB} env
during testing this was actually not needed

Which issue(s) does this PR fix or relate to

• Fixes #issue_number

PR acceptance criteria

• Tests updated and passing
• Documentation updated
• Built-in TechDocs updated if needed. Note that TechDocs changes may need to be reviewed by a Product Manager and/or Architect to ensure content accuracy, clarity, and alignment with user needs.

How to test changes / Special notes to the reviewer

[rhdh-qodo-merge]

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0)

1. Stale POSTGRES_DB variable 🐞 Bug ⚙ Maintainability

Description

The PostgreSQL guide removes the use of ${POSTGRES_DB}, but the repo still ships POSTGRES_DB in
default.env, leaving the documentation and default environment template inconsistent and potentially
confusing for users configuring Postgres.

Code

docs/rhdh-local-guide/postgresql-guide.md[83]

-         database: ${POSTGRES_DB}

Relevance

⭐⭐⭐ High

Team often aligns docs with default.env to avoid confusion (e.g., env var docs sync in PR #149;
default.env alignment PR #57).

PR-#149
PR-#57

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The guide’s Postgres connection snippets now only include host/port/user/password and no longer
include a database name placeholder, but default.env still defines POSTGRES_DB, implying users may
need or can configure it even though the guide no longer mentions it.

docs/rhdh-local-guide/postgresql-guide.md[61-83]
default.env[1-6]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The Postgres guide no longer references `${POSTGRES_DB}`, but `default.env` still defines `POSTGRES_DB`, creating an inconsistency for users following the documented setup.

### Issue Context
Either the variable is truly unnecessary and should be removed from the default environment template, or it should be documented as optional/when needed (e.g., when using a non-default database).

### Fix Focus Areas
- default.env[1-6]
- docs/rhdh-local-guide/postgresql-guide.md[61-83]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. Missing newline at EOF 🐞 Bug ⚙ Maintainability

Description

docs/rhdh-local-guide/postgresql-guide.md is missing a trailing newline, which causes noisy diffs
and can trigger formatting/lint issues in some tooling.

Code

docs/rhdh-local-guide/postgresql-guide.md[83]

</details>

Relevance

⭐⭐ Medium

No clear historical review pattern found about enforcing trailing newline/EOF formatting in docs
files.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The PR diff explicitly marks the file as lacking a newline at end-of-file after this edit.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The markdown file ends without a trailing newline.

### Issue Context
Git marks this as `\ No newline at end of file`; adding a final newline avoids future diff noise and tooling warnings.

### Fix Focus Areas
- docs/rhdh-local-guide/postgresql-guide.md[83-83]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rhdh-qodo-merge]

Review Summary by Qodo

Remove unnecessary POSTGRES_DB environment variable from docs

📝 Documentation

Walkthroughs

Description

• Remove unnecessary database: ${POSTGRES_DB} environment variable from PostgreSQL configuration
  example
• Simplifies documentation by eliminating unused configuration parameter

Diagram

flowchart LR
  A["PostgreSQL Guide Documentation"] -- "Remove unused database env var" --> B["Simplified Configuration Example"]

Loading

File Changes

1. docs/rhdh-local-guide/postgresql-guide.md 📝 Documentation +0/-1

Remove unused POSTGRES_DB environment variable

• Removed database: ${POSTGRES_DB} line from PostgreSQL configuration example
• Simplifies the configuration snippet by eliminating an unused environment variable
• Configuration now only includes essential parameters: port, user, and password

docs/rhdh-local-guide/postgresql-guide.md

---