Add support for Pbench agent installation#315
Add support for Pbench agent installation#315asyedham wants to merge 2 commits intoredhat-performance:masterfrom
Conversation
asyedham
force-pushed
the
pbench-support
branch
7 times, most recently
from
85e7471 to
07a27b3
Compare
asyedham
force-pushed
the
pbench-support
branch
2 times, most recently
from
77fb63f to
a580142
Compare
asyedham
changed the title
asyedham
force-pushed
the
pbench-support
branch
3 times, most recently
from
8f598e0 to
320d667
Compare
To install Pbench agent on the compute nodes and vm's (i.e client and server),you have to follow the below steps and set the below params install/group_vars/all.yml
`pbench_key_url: <pbench_key_url>
pbench_config_url: <pbench_config_url>
pbench_configuration_environment: <pbench_configuration_environment>`
`cd {{ ansible_user_dir}}/jetpack/install`
1) To create the client and server
`ansible-playbook boot.yml`
2) Install Pbench agent bootstrapping
`ansible-playbook pbench_agent_bootstrap.yml -e "repos=<perf-dept-repo>" `
3) Install Pbench agent install
`ansible-playbook pbench_agent_install.yml`
asyedham
force-pushed
the
pbench-support
branch
from
320d667 to
f1f282b
Compare
portante
left a comment
portante
left a comment
There was a problem hiding this comment.
Do you mean to check in install/templates/.pass_auth.sh.j2.swp?
| become: yes | ||
| loop: | ||
| - "{{ epel_repo.el7 }}" | ||
| - perl-Data-UUID |
There was a problem hiding this comment.
Why do you have to install perl-Data-UUID?
There was a problem hiding this comment.
These will install perl-Data-UUID after the epel is installed on computes as by default the yum repos are disabled
There was a problem hiding this comment.
But why is this needed explicitly? The pbench-agent RPM should have dependencies that take care of this.
| - "{{ vm_names }}" | ||
| ignore_errors: yes | ||
|
|
||
| - name: create a vm's |
There was a problem hiding this comment.
Why are there two roles that are named the same and seem to do almost the same thing?
There was a problem hiding this comment.
There are two tasks for idempotency because
- In the first task it creates Uperf client and server vm, so it uses UUID's of the ports registered in var
port_idsthat were created newly if these ports didn't exist - The second task creates uperf client and server vm's using the UUID of the ports already exist registered in
get_port_idsvar
There was a problem hiding this comment.
Why not just have one task handle this?
| sudo dnf install {{ epel_repo.el8 }} -y | ||
| sudo dnf module install -y python36 | ||
| sudo alternatives --set python /usr/bin/python3 | ||
| sudo dnf --enablerepo=PowerTools install perl-Data-UUID -y |
There was a problem hiding this comment.
Why do you need to explicitly install perl-Data-UUID here and not for CentOS 7? Don't you have this requirement elsewhere?
There was a problem hiding this comment.
I had seen this requirement in the Pbench installation documentation. But I just checked the doc and can't find it now
There was a problem hiding this comment.
The pbench-agent RPM should have its own dependencies. I'd suggest removing this to confirm.
| @@ -0,0 +1,108 @@ | |||
| --- | |||
|
|
|||
| # Playbook to create client and server vm on Openstack | |||
There was a problem hiding this comment.
Can this be factored out into its own PR as it does not appear to be tightly related to pbench agent installation?
There was a problem hiding this comment.
This PR supports Pbench agent installation on Openstack Vm's, Computes, and Trafficgen host if enabled. This playbook creates the Uperf client and server vm.
There was a problem hiding this comment.
Sure, but this playbook appears to be completely independent of what it is being used for, which makes it verifiable on its own and not tied to anything pbench.
asyedham
force-pushed
the
pbench-support
branch
from
f1f282b to
8492e26
Compare
|
@portante Thanks for reviewing my PR. |
asyedham
force-pushed
the
pbench-support
branch
from
8492e26 to
674f501
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
3 participants
[skip-ci]
boot_vm.yml, playbook creates an uperf client and server vm
pbench_agent_bootstrap.yml, playbook installs necessary repos.
pbench_agent_install.yml, playbook install pbench agent on vm's and compute nodes
#320