This repository was archived by the owner on Aug 21, 2024. It is now read-only.
transformer: Filter images by their unique references instead of names#631
Open
poncovka wants to merge 1 commit intoredhatcloudx:mainfrom
Open
transformer: Filter images by their unique references instead of names#631poncovka wants to merge 1 commit intoredhatcloudx:mainfrom
poncovka wants to merge 1 commit intoredhatcloudx:mainfrom
Conversation
If there are multiple images with the same reference, use only the latest image. For example, the `v1/aws/us-east-1/rhel_9.1.0_hvm_x86_64_hourly2` reference can be used by only one image provided by the CID and it should be the latest one.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
miyunari
reviewed
Jul 3, 2023
| name = entry.content["name"] | ||
| # Compare the data entry with the last inserted entry with | ||
| # the same reference. If the new entry is older, do nothing. | ||
| ref = entry.filename |
Member
There was a problem hiding this comment.
I cant follow 100%, could you help me and explain the details a bit? :)
My understanding is that the filename is always unique, so that we never need to compare it with other image data and never filter something? 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are multiple images with the same reference, use only the latest image. For example, the
v1/aws/us-east-1/rhel_9.1.0_hvm_x86_64_hourly2reference can be used by only one image provided by the CID and it should be the latest one.