Skip to content

Adds optional TTL argument to Metastore#write #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radar merged 1 commit into from
Aug 31, 2015
Merged

Adds optional TTL argument to Metastore#write #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/rack/cache/redis_metastore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,12 @@ def read(key)
cache.get(hexdigest(key)) || []
end

def write(key, entries)
cache.set(hexdigest(key), entries)
def write(key, entries, ttl=0)
if ttl.zero?
cache.set(hexdigest(key), entries)
else
cache.setex(hexdigest(key), ttl, entries)
end
end

def purge(key)
Expand Down
9 changes: 8 additions & 1 deletion test/rack/cache/metastore/redis_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ def self.call(request); request.path_info.reverse end
store_simple_entry('/bad', { 'SOME_THING' => Proc.new {} })
end

it 'takes a ttl parameter for #write' do
@store.write('/foo', [[{},{}]], 123)
data = @store.read('/foo')
data.must_equal([[{},{}]])
end


# Abstract methods ===========================================================

it 'stores a cache entry' do
Expand Down Expand Up @@ -266,4 +273,4 @@ def self.call(request); request.path_info.reverse end
define_method :uri do |uri|
URI.parse uri
end
end
end