-
Notifications
You must be signed in to change notification settings - Fork 384
[RI-6570] Playwright E2E tests #4615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
plus comments
Code Coverage - Integration Tests
|
Code Coverage - Backend unit tests
Test suite run success2941 tests passing in 286 suites. Report generated by 🧪jest coverage report action from 16a940a |
Code Coverage - Frontend unit tests
Test suite run success4792 tests passing in 628 suites. Report generated by 🧪jest coverage report action from 16a940a |
|
The electron tests fail with the following on Linux (after updating the path to the built version. Do they work on Mac? Running 7 tests using 1 worker (Use (Use
[Chromium] › tests/keys.spec.ts:48:9 › Adding Database Keys › Verify that user can add Set Key (Use
[Chromium] › tests/keys.spec.ts:58:9 › Adding Database Keys › Verify that user can add List Key (Use
[Chromium] › tests/keys.spec.ts:68:9 › Adding Database Keys › Verify that user can add String Key (Use
[Chromium] › tests/keys.spec.ts:78:9 › Adding Database Keys › Verify that user can add ZSet Key (Use
[Chromium] › tests/keys.spec.ts:89:9 › Adding Database Keys › Verify that user can add Stream key (Use
6 failed Serving HTML report at http://localhost:37641. Press Ctrl+C to quit. |
@@ -6,3 +6,4 @@ RI_NOTIFICATION_UPDATE_URL=https://s3.amazonaws.com/redisinsight.test/public/tes | |||
RI_NOTIFICATION_SYNC_INTERVAL=30000 | |||
RI_FEATURES_CONFIG_URL=http://static-server:5551/remote/features-config.json | |||
RI_FEATURES_CONFIG_SYNC_INTERVAL=50000 | |||
TEST_BIG_DB_DUMP=https://s3.amazonaws.com/redisinsight.test/public/rte/dump/big/dump.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit odd that we have an .env
file committed in the repo, but yeah - this file was here before your PR.
Still, I believe it's better to keep these configs as environment variables - maybe we can offload it as a separate tech debt and take a look later?
@@ -0,0 +1,130 @@ | |||
/* eslint-disable max-len */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary, or is it a leftover from some tests?
Description
Adds Playwright E2E tests. Also enables CI E2E tests for PRs.
See README.md for more details.
Notes