Skip to content

[RI-6570] Detach E2E workflows #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 8 additions & 23 deletions .github/workflows/tests-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,27 +11,22 @@ on:
default: false
type: boolean

workflow_call:
inputs:
debug:
description: Enable SSH Debug
default: false
type: boolean

# Cancel a previous run workflow
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-e2e
cancel-in-progress: true

jobs:
# # E2E Approve
# E2E Approve
e2e-approve:
runs-on: ubuntu-latest
# TODO: uncomment when on push trigger is removed
# if: github.event.review.state == 'approved' || github.event_name == 'workflow_dispatch'
if: github.event.review.state == 'approved' && !contains(github.event.pull_request.labels.*.name, 'e2e-approved') || github.event_name == 'workflow_dispatch'
name: Approve E2E tests
steps:
- run: echo "Proceeding with E2E tests"
- name: Add "e2e-approved" Label
uses: actions-ecosystem/action-add-labels@v1
with:
labels: e2e-approved

# E2E Docker
build-docker:
Expand Down Expand Up @@ -75,22 +70,12 @@ jobs:
clean:
uses: ./.github/workflows/clean-deployments.yml
if: always()
needs:
[
e2e-docker-tests,
e2e-appimage-tests,
tests-e2e-playwright,
]
needs: [e2e-docker-tests, e2e-appimage-tests, tests-e2e-playwright]

# Remove artifacts from github actions
remove-artifacts:
name: Remove artifacts
needs:
[
e2e-docker-tests,
e2e-appimage-tests,
tests-e2e-playwright,
]
needs: [e2e-docker-tests, e2e-appimage-tests, tests-e2e-playwright]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,6 @@ jobs:
resource_name: integration-coverage
type: integration

# TODO: remove this after ✅ E2E Tests workflow is available in main
e2e-tests:
uses: ./.github/workflows/tests-e2e.yml
needs: changes
secrets: inherit
with:
debug: ${{ inputs.debug || false }}

clean:
uses: ./.github/workflows/clean-deployments.yml
if: always()
Expand Down
Loading