RI-6855 Added title for the new vector search page #4957
+39
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valkirilov
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko and
pd-redis
as code owners
Code Coverage - Frontend unit tests
Test suite run success5128 tests passing in 676 suites. Report generated by 🧪jest coverage report action from 37a2973 |
valkirilov
force-pushed
the
fe/feature/vector-search-page-title
branch
from
336a609 to
37a2973
Compare
valkirilov
commented
Sep 15, 2025
| @@ -3,13 +3,6 @@ import { cleanup, render, screen, userEvent } from 'uiSrc/utils/test-utils' | |||
| import { HeaderActions, HeaderActionsProps } from './HeaderActions' | |||
| import useRedisInstanceCompatibility from '../create-index/hooks/useRedisInstanceCompatibility' | |||
|
|
|||
| // Workaround for @redis-ui/components Title component issue with react-children-utilities | |||
There was a problem hiding this comment.
Note: This is not related to the change of the title, but removing this, since it was reported that the issue was resolved by removing a custom mock, made on a global level a few years ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a title for the new Vector Search page, following the pattern described by the rest of the available pages (Browse, Workbench, etc.)