-
Notifications
You must be signed in to change notification settings - Fork 421
RI-7774 Fix Copilot button styles #5243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…onents Migrated CopilotTrigger component from SCSS modules to styled-components following the project's migration guidelines. Replaced styles.module.scss with CopilotTrigger.styles.ts using FlexGroup and IconButton styled components. Removed classnames dependency and improved type safety. References: #RI-7774
4eaf25d to
70f78ce
Compare
| isOpen && | ||
| css` | ||
| background-color: ${({ theme }) => | ||
| theme.semantic.color.background.primary200}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing important flag on background color
The background-color property when isOpen is true lacks the !important flag that was present in the original SCSS implementation. The similar BulbIconButton in the insights trigger uses !important for the same property. Without this flag, the background color may not apply correctly if conflicting styles exist with higher specificity, breaking the visual indication that the panel is open.
| svg { | ||
| width: 21px; | ||
| height: 21px; | ||
| color: var(--triggerIconActiveColor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing important flag on SVG color
The SVG color property lacks the !important flag that was present in the original SCSS implementation. Without this flag, the icon color may be overridden by other styles with higher specificity, potentially breaking the visual appearance of the Copilot icon.
redisinsight/ui/src/components/triggers/copilot-trigger/CopilotTrigger.styles.ts
Show resolved
Hide resolved
redisinsight/ui/src/components/triggers/copilot-trigger/CopilotTrigger.styles.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ The following Jit checks failed to run:
- secret-detection-trufflehog
#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.
More info in the Jit platform.
See #5247