Skip to content

Conversation

@valkirilov
Copy link
Member

@valkirilov valkirilov commented Nov 26, 2025

See #5247

@valkirilov valkirilov self-assigned this Nov 26, 2025
@valkirilov valkirilov changed the title refactor(ui): migrate CopilotTrigger from SCSS modules to styled-comp… RI-7774 Fix Copilot button styles Nov 26, 2025
@valkirilov valkirilov marked this pull request as ready for review November 26, 2025 13:41
Base automatically changed from docs/introduce-ai-rules to main November 26, 2025 14:30
…onents

Migrated CopilotTrigger component from SCSS modules to styled-components
following the project's migration guidelines. Replaced styles.module.scss
with CopilotTrigger.styles.ts using FlexGroup and IconButton styled components.
Removed classnames dependency and improved type safety.

References: #RI-7774
@valkirilov valkirilov force-pushed the refactor/RI-7774/migrate-copilot-trigger-styles branch from 4eaf25d to 70f78ce Compare November 26, 2025 14:42
isOpen &&
css`
background-color: ${({ theme }) =>
theme.semantic.color.background.primary200};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing important flag on background color

The background-color property when isOpen is true lacks the !important flag that was present in the original SCSS implementation. The similar BulbIconButton in the insights trigger uses !important for the same property. Without this flag, the background color may not apply correctly if conflicting styles exist with higher specificity, breaking the visual indication that the panel is open.

Fix in Cursor Fix in Web

svg {
width: 21px;
height: 21px;
color: var(--triggerIconActiveColor);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing important flag on SVG color

The SVG color property lacks the !important flag that was present in the original SCSS implementation. Without this flag, the icon color may be overridden by other styles with higher specificity, potentially breaking the visual appearance of the Copilot icon.

Fix in Cursor Fix in Web

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ The following Jit checks failed to run:

  • secret-detection-trufflehog

#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.

More info in the Jit platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants