RI-7799: Bulk delete in batches #5256
Draft
+177
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The current bulk delete implementation keeps all deleted keys in memory. When the number grows large (e.g., around 1M keys), the backend eventually crashes.
This PR introduces batch processing to avoid that issue.
However, reports now only return the keys from the last processed batch, meaning the user can no longer see the complete list of deleted keys. So that's why I implemented #5257
Testing
Before
Fill a database with enough keys (depending on your RAM), and bulk delete them all.
Screen.Recording.2025-11-27.at.15.33.02.mov
After
Screen.Recording.2025-11-27.at.15.28.09.mov