K8s: Zeppelin maint 1 - INE cert changes #2424
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
ronnybaturov-redis
left a comment
ronnybaturov-redis
left a comment
There was a problem hiding this comment.
Looks good, left minor comments
| </td> | ||
| <td>false</td> | ||
| </tr><tr> | ||
| <td>cpInterNodeEncryptionCertificateSecretName</td> |
There was a problem hiding this comment.
Can you please change this to Intenode... Instead of InterNode with a lower case N?
This was the final name which has been chosen in my PR to conform with officials docs
| </td> | ||
| <td>false</td> | ||
| </tr><tr> | ||
| <td>dpInterNodeEncryptionCertificateSecretName</td> |
There was a problem hiding this comment.
ditto (and many more in this PR)
| ### Prerequisites | ||
| - Internode encryption must be enabled (`dataInternodeEncryption: true`) |
There was a problem hiding this comment.
I don’t think that’s accurate. Could you provide a reference if I’m mistaken?
This feature should allow customers to use their own certificates without requiring them to use self-signed certificates first. Enabling the dataInternodeEncryption field, however, forces customers to use self-signed certificates.
| ### Prerequisites | ||
| - Internode encryption must be enabled (`dataInternodeEncryption: true`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-5988