Added hybrid search command #3573
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndyakov
reviewed
Nov 5, 2025
* Add support for XReadGroup CLAIM argument * modify tutorial tests --------- Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
* feat: add acl support and command test * validate client name before kill it --------- Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
* improvements * linter fixes * prevention on unnecessary allocations in case of bad configuration * Test/Benchmark, old code with safety harness preventing panic --------- Co-authored-by: manish <manish.sharma@manifestit.io> Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
* support for latency command * add NonRedisEnterprise label for latency test
* Add support for certain slowlog commands * add NonRedisEnterprise label for slow reset test --------- Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
* add cas/cad commands
* feat(command): Add SetIFDEQ, SetIFDNE and *Get cmds
Decided to move the *Get argument as a separate methods, since the
response will be always the previous value, but in the case where
the previous value is `OK` there result may be ambiguous.
* fix tests
* matchValue to be interface{}
* Only Args approach for DelEx
* use uint64 for digest, add example
* test only for 8.4
htemelski-redis
force-pushed
the
hybrid-search
branch
from
7d6c0a2 to
0bc0888
Compare
ndyakov
approved these changes
Nov 10, 2025
Member
ndyakov
left a comment
ndyakov
left a comment
There was a problem hiding this comment.
left couple comments, other than that lgtm.
Comment on lines
+2586
to
+2589
| for _, field := range options.Load { | ||
| // Redis requires field names in LOAD to be prefixed with '@' (or '$' for JSON paths). | ||
| // Tests pass plain field names (e.g. "description"), so add the '@' prefix here. | ||
| args = append(args, "@"+field) |
Member
There was a problem hiding this comment.
shoudn't the user decide if he/she would like to use plain fields or json paths? hence we should not prefix, but the user should pass @field or $path.name ?
Comment on lines
+2616
to
+2618
| if fieldName != "" && fieldName[0] != '@' && fieldName[0] != '$' { | ||
| fieldName = "@" + fieldName | ||
| } |
Member
There was a problem hiding this comment.
similar here, we are checking if there is a prefix, we can do the same for load. yes, it makes some sense to autoprefix @ if there is no prefix, but this is debatable. how are other clients handling this?
| type FTHybridVectorExpression struct { | ||
| VectorField string | ||
| VectorData Vector | ||
| Method string // KNN or RANGE |
Member
There was a problem hiding this comment.
should we have those KNN and RANGE defined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the new ft.hybrid command.
Test are adapted version of the redis-py tests redis/redis-py#3813