Make a bridge between JedisPool and JedisPooled #4371
+487
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add unit test to verify connection is returned to the pool
Add helpers to Jedis pool (redis#4366)
more tests and renamed interface
more unir tests
renamed to JedisProvider make return connection better tests
make a bridge between JedisPool and JedisPooled
little fixes
Contributor
Author
|
It gives me this error
But I don't know how to fix it, I don't see how to propertly make it valid. |
Collaborator
|
Hi @oscar-besga-panel Regarding the formatting issue, please run: |
Contributor
Author
|
Hi @ggivo Tks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intented to make a bridge between JedisPool and JedisPooled by making these two share a common interface JedisProvider.
JedisProvider provides methods to get and return a Jedis connection; and also helpers to use within a lambda.
Jedis is modified to return the connection when closed to the appropiate pool.
JedisPooled implements the method to get and return a Jedis object by providing the connection and the source pool, and to return this connection to the pool.
Also it has unit and funcional test to check everything.
I'm not sure if this is adecuate rigth now, if there's a neeed for it (in my project I'm already migrating from JedisPool to JedisPooled).
But if it serves, or you have detected the need for it, I think this could be the way to do it.
Thanks for your time