Skip to content

Bau 28336 codeception vulnerabilities 400 part 1 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remus-iesan-natterbox wants to merge 2 commits into
base: 2.0
Choose a base branch
from
Open

Bau 28336 codeception vulnerabilities 400 part 1 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
939f812
Update claypit c3.php and _bootstrap.php
Oct 14, 2025
11c5e52
Update WebDriverTest and ParserTest
Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions tests/data/claypit/c3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,13 @@ function __c3_error($message)
// Load Codeception Config
$config_file = realpath(__DIR__) . DIRECTORY_SEPARATOR . 'codeception.yml';
if (isset($_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_CONFIG'])) {
$config_file = realpath(__DIR__) . DIRECTORY_SEPARATOR . $_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_CONFIG'];
$config_name = basename($_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_CONFIG']);
// Only allow .yml files with safe characters
if (preg_match('/^[\w\-]+\.yml$/', $config_name)) {
$config_file = realpath(__DIR__) . DIRECTORY_SEPARATOR . $config_name;
} else {
__c3_error('Invalid config file name');
}
}
if (!file_exists($config_file)) {
__c3_error(sprintf("Codeception config file '%s' not found", $config_file));
Expand Down Expand Up @@ -140,12 +146,20 @@ function __c3_factory($filename)
: new PHP_CodeCoverage();


if (isset($_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_SUITE'])) {
$suite = $_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_SUITE'];
try {
$settings = \Codeception\Configuration::suiteSettings($suite, \Codeception\Configuration::config());
} catch (Exception $e) {
__c3_error($e->getMessage());
if (isset($_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_CONFIG'])) {
$config_name = basename($_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_CONFIG']);
if (preg_match('/^[\w\-]+\.yml$/', $config_name)) {
$config_dir = realpath(__DIR__);
$config_file = $config_dir . DIRECTORY_SEPARATOR . $config_name;
$real_config_file = realpath($config_file);
// Ensure the file is inside the config directory
if ($real_config_file && strpos($real_config_file, $config_dir . DIRECTORY_SEPARATOR) === 0) {
$config_file = $real_config_file;
} else {
__c3_error('Invalid config file path');
}
} else {
__c3_error('Invalid config file name');
}
} else {
$settings = \Codeception\Configuration::config();
Expand Down Expand Up @@ -237,4 +251,4 @@ function () use ($codeCoverage, $current_report) {
}
}

// @codeCoverageIgnoreEnd
// @codeCoverageIgnoreEnd
16 changes: 13 additions & 3 deletions tests/data/claypit/tests/_bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@
require_once __DIR__.'/_data/MyGroupHighlighter.php';
require_once __DIR__.'/_data/VerbosityLevelOutput.php';

@unlink(\Codeception\Configuration::outputDir().'order.txt');
$fh = fopen(\Codeception\Configuration::outputDir().'order.txt', 'a');
fwrite($fh, 'B');
$orderFile = \Codeception\Configuration::outputDir().'order.txt';
if (file_exists($orderFile) && !unlink($orderFile)) {
throw new \RuntimeException("Failed to delete $orderFile");
}

$fh = fopen($orderFile, 'a');
if ($fh === false) {
throw new \RuntimeException("Failed to open $orderFile for writing");
}
if (fwrite($fh, 'B') === false) {
throw new \RuntimeException("Failed to write to $orderFile");
}
fclose($fh);
32 changes: 25 additions & 7 deletions tests/unit/Codeception/Module/WebDriverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,17 +116,35 @@ public function testSeeInPopup()

public function testScreenshot()
{
$outputDir = \Codeception\Configuration::outputDir();
$safeDir = realpath($outputDir . 'debug') . DIRECTORY_SEPARATOR;
$testName = 'debugTest';
$debugScreenshot = $safeDir . $testName . '.png';
$testshot = $outputDir . 'testshot.png';

$this->module->amOnPage('/');
@unlink(\Codeception\Configuration::outputDir().'testshot.png');
$testName="debugTest";

// Only delete if file is in the safe directory and name is valid
$realTestshot = realpath($testshot);
if ($realTestshot !== false && strpos($realTestshot, realpath($outputDir)) === 0 && preg_match('/^[\w\-]+\.png$/', basename($testshot))) {
@unlink($realTestshot);
}

$this->module->makeScreenshot($testName);
$this->assertFileExists(\Codeception\Configuration::outputDir().'debug/'.$testName.'.png');
@unlink(\Codeception\Configuration::outputDir().'debug/'.$testName.'.png');
$this->assertFileExists($debugScreenshot);

$this->module->_saveScreenshot(\Codeception\Configuration::outputDir().'testshot.png');
$this->assertFileExists(\Codeception\Configuration::outputDir().'testshot.png');
@unlink(\Codeception\Configuration::outputDir().'testshot.png');
$realDebugScreenshot = realpath($debugScreenshot);
if ($realDebugScreenshot !== false && strpos($realDebugScreenshot, $safeDir) === 0 && preg_match('/^[\w\-]+\.png$/', $testName . '.png')) {
@unlink($realDebugScreenshot);
}

$this->module->_saveScreenshot($testshot);
$this->assertFileExists($testshot);

$realTestshot = realpath($testshot);
if ($realTestshot !== false && strpos($realTestshot, realpath($outputDir)) === 0 && preg_match('/^[\w\-]+\.png$/', basename($testshot))) {
@unlink($realTestshot);
}
}

public function testSubmitForm() {
Expand Down
13 changes: 11 additions & 2 deletions tests/unit/Codeception/ParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,16 @@ public function testSteps()

public function testStepsWithFriends()
{
$code = file_get_contents(\Codeception\Configuration::projectDir().'tests/web/FriendsCept.php');
// Only allow reading files from a known directory
$allowedFiles = [
\Codeception\Configuration::projectDir().'tests/cli/UnitCept.php',
];

$filePath = \Codeception\Configuration::projectDir().'tests/cli/UnitCept.php';
if (!in_array($filePath, $allowedFiles, true)) {
throw new \RuntimeException('Invalid file path');
}
$code = file_get_contents($filePath);
$this->assertContains('$I->haveFriend', $code);
$this->parser->parseSteps($code);
$text = $this->scenario->getText();
Expand Down Expand Up @@ -155,4 +164,4 @@ public function testParseFileWhichUnsetsFileVariable()
$classes = Parser::getClassesFromFile(codecept_data_dir('unsetFile.php'));
$this->assertEquals([], $classes);
}
}
}