Skip to content

Record failed attempt on reveal, dark mode chord tones, remote screenshot tests#270

Merged
rednebmas merged 5 commits intomainfrom
reveal-attempt-dark-mode-screenshot-tests
Mar 3, 2026
Merged

Record failed attempt on reveal, dark mode chord tones, remote screenshot tests#270
rednebmas merged 5 commits intomainfrom
reveal-attempt-dark-mode-screenshot-tests

Conversation

@rednebmas
Copy link
Copy Markdown
Owner

Summary

  • Record a failed spaced-repetition attempt when "Reveal answer" is clicked, so revealed cards are tracked as incorrect
  • Add dark mode Tailwind variants to ChordToneDisplay component (tone chips + container)
  • Add scripts/test-screenshots-remote.sh and yarn test:screenshots:remote for running Playwright screenshot tests via GitHub Actions
  • Replace CLAUDE.md symlink with @AGENTS.md import, document screenshot test workflow in AGENTS.md

Test plan

  • Verify screenshot tests pass (this PR triggers them automatically)
  • Verify reveal action records a failed attempt in spaced repetition
  • Verify chord tone display looks correct in dark mode

🤖 Generated with Claude Code

rednebmas and others added 4 commits December 31, 2025 19:37
Allow keyboard to scroll horizontally when it overflows the viewport
while preventing unwanted horizontal scroll at the layout level.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Allow both Codex and Claude Code to use the same project instructions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…shot tests

- Record a failed spaced-repetition attempt when "Reveal answer" is clicked
- Add dark mode Tailwind variants to ChordToneDisplay component
- Add remote screenshot test script and yarn shortcut
- Replace CLAUDE.md symlink with @AGENTS.md import
- Document screenshot test workflow and sandbox requirements in AGENTS.md

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2026

🔴 Test Failures Detected

Below is a gallery of each test’s actual vs diff. Click to view full-size or run locally:

View the full Playwright report here.


custom-deck-notation-to-study-notation-input-edit

Screenshot
Actual actual
Expected expected
Diff diff

custom-deck-text-to-study-cross-clef-notation

Screenshot
Actual actual
Expected expected
Diff diff

notation-input-text-prompt

Screenshot
Actual actual
Expected expected
Diff diff

To update all screenshot snapshots, run the Update Screenshot Test PNGs workflow.

The Layout component changed from overflow-scroll to overflow-y-auto
in 2457df9, but the test scroll helpers still queried .overflow-scroll,
causing screenshots to capture at wrong scroll positions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rednebmas rednebmas merged commit fdd31b6 into main Mar 3, 2026
2 checks passed
@rednebmas rednebmas deleted the reveal-attempt-dark-mode-screenshot-tests branch March 3, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant